Lightbeam completely busted on mozilla-inbound trunk builds

[nnethercote]

I just tried Lightbeam on mozilla-inbound trunk builds on both Mac and Linux. It's completely busted on both. None of the buttons on the Lightbeam page do anything: 'Graph', 'List', 'Save Data', 'Reset Data', '?', or 'i'. And the 'Contribute Data' switch is broken. I tried both with and without e10s, but it didn't make any difference.

I see some "TypeError: button is undefined" messages in the browser console.

[fmarier]

@nnethercote The e10s problems are tracked on https://bugzilla.mozilla.org/show_bug.cgi?id=1053007, but you're right it's worst than that. In my testing it was also unusable on Fx 35.

[nnethercote]

I bisected the bustage. Part 1 of https://bugzilla.mozilla.org/show_bug.cgi?id=611388 caused it. I guess there are some now-bad uses of const in Lightbeam.

(BTW, the graph view was broken for me prior to that patch, but at least the rest of it, particularly the list view, was usable.)

[efaust]

I wrote that commit in FF. It makes const lexically scoped, so some old idioms no longer work as intended. It was common to want things like

if (cond) {
    const x = foo;
}

or

try { 
    const x = someFunctionWhichMightThrow();
} catch (e) { }

expecting that declaration to be hoisted out of the enclosing block, but that is no longer going to work. While this is unfortunate, it's a spec-level decision that's been made for ES6, so we are heading in that direction.

At any rate, the fix should be fairly trivial.

[fmarier]

#624 fixed the main UI issues, the graph is still not visible though

[monicachew]

Sure looks like something is failing to create the d3 image.

console.debug: lightbeam:
updateGraph()
[70592] WARNING: NS_ENSURE_SUCCESS(rv, BadImage(newImage)) failed with resul
t 0x80540006: file /Users/mchew/mozilla-central/image/src/ImageFactory.cpp,
line 199
[70592] WARNING: NS_ENSURE_SUCCESS(rv, BadImage(newImage)) failed with resul
t 0x80540006: file /Users/mchew/mozilla-central/image/src/ImageFactory.cpp,
line 199

[nnethercote]

I also initially see no graph. But if I click on the '?' button the graph suddenly appears.

[nnethercote]

Oh! Before hitting the '?' button it seems the graph is showing, but the actual nodes are way off to the side so they can't be seen. Somehow the '?' button centres the graph. If you switch to 'list' view and then back to 'graph' view the graph again gets moved to a non-visible or only-slight-visible location.

[monicachew]

That might explain why I'm having trouble bisecting. I got to https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=5c38e0a84b54&tochange=b489ff052163 but am having trouble reproducing.