Skip to content
This repository has been archived by the owner. It is now read-only.

Lightbeam completely busted on mozilla-inbound trunk builds #622

Closed
nnethercote opened this issue Nov 11, 2014 · 8 comments
Closed

Lightbeam completely busted on mozilla-inbound trunk builds #622

nnethercote opened this issue Nov 11, 2014 · 8 comments
Milestone

Comments

@nnethercote
Copy link

@nnethercote nnethercote commented Nov 11, 2014

I just tried Lightbeam on mozilla-inbound trunk builds on both Mac and Linux. It's completely busted on both. None of the buttons on the Lightbeam page do anything: 'Graph', 'List', 'Save Data', 'Reset Data', '?', or 'i'. And the 'Contribute Data' switch is broken. I tried both with and without e10s, but it didn't make any difference.

I see some "TypeError: button is undefined" messages in the browser console.

@fmarier

This comment has been minimized.

Copy link
Contributor

@fmarier fmarier commented Nov 11, 2014

@nnethercote The e10s problems are tracked on https://bugzilla.mozilla.org/show_bug.cgi?id=1053007, but you're right it's worst than that. In my testing it was also unusable on Fx 35.

@fmarier fmarier modified the milestone: 1.0.10 - improve data utility Nov 11, 2014
@nnethercote

This comment has been minimized.

Copy link
Author

@nnethercote nnethercote commented Nov 11, 2014

I bisected the bustage. Part 1 of https://bugzilla.mozilla.org/show_bug.cgi?id=611388 caused it. I guess there are some now-bad uses of const in Lightbeam.

(BTW, the graph view was broken for me prior to that patch, but at least the rest of it, particularly the list view, was usable.)

@efaust

This comment has been minimized.

Copy link

@efaust efaust commented Nov 11, 2014

I wrote that commit in FF. It makes const lexically scoped, so some old idioms no longer work as intended. It was common to want things like

if (cond) {
    const x = foo;
}

or

try { 
    const x = someFunctionWhichMightThrow();
} catch (e) { }

expecting that declaration to be hoisted out of the enclosing block, but that is no longer going to work. While this is unfortunate, it's a spec-level decision that's been made for ES6, so we are heading in that direction.

At any rate, the fix should be fairly trivial.

monicachew pushed a commit that referenced this issue Nov 11, 2014
Remove australis checks (Fixes DOA in #622)
@fmarier

This comment has been minimized.

Copy link
Contributor

@fmarier fmarier commented Nov 11, 2014

#624 fixed the main UI issues, the graph is still not visible though

@monicachew

This comment has been minimized.

Copy link

@monicachew monicachew commented Nov 12, 2014

Sure looks like something is failing to create the d3 image.

console.debug: lightbeam:
updateGraph()
[70592] WARNING: NS_ENSURE_SUCCESS(rv, BadImage(newImage)) failed with resul
t 0x80540006: file /Users/mchew/mozilla-central/image/src/ImageFactory.cpp,
line 199
[70592] WARNING: NS_ENSURE_SUCCESS(rv, BadImage(newImage)) failed with resul
t 0x80540006: file /Users/mchew/mozilla-central/image/src/ImageFactory.cpp,
line 199

@nnethercote

This comment has been minimized.

Copy link
Author

@nnethercote nnethercote commented Nov 12, 2014

I also initially see no graph. But if I click on the '?' button the graph suddenly appears.

@nnethercote

This comment has been minimized.

Copy link
Author

@nnethercote nnethercote commented Nov 12, 2014

Oh! Before hitting the '?' button it seems the graph is showing, but the actual nodes are way off to the side so they can't be seen. Somehow the '?' button centres the graph. If you switch to 'list' view and then back to 'graph' view the graph again gets moved to a non-visible or only-slight-visible location.

@monicachew

This comment has been minimized.

Copy link

@monicachew monicachew commented Nov 12, 2014

That might explain why I'm having trouble bisecting. I got to https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=5c38e0a84b54&tochange=b489ff052163 but am having trouble reproducing.

@fmarier fmarier closed this in 7c99d44 Nov 14, 2014
@fmarier fmarier added this to the 1.0.11 milestone Nov 18, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.