Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

build mdb.c without optimizations for debug build #54

Closed
mykmelez opened this issue Jun 21, 2019 · 0 comments · Fixed by #56
Closed

build mdb.c without optimizations for debug build #54

mykmelez opened this issue Jun 21, 2019 · 0 comments · Fixed by #56

Comments

@mykmelez
Copy link

lmdb-sys/build.rs sets .opt_level(2) unconditionally, with a comment that references that setting in LMDB's Makefile. But that's unhelpful when building a debug build of the test executables for debugging in a debugger. So we should set an optimization level in lmdb-sys/build.rs only when building --release builds.
victorporof added a commit that referenced this issue Aug 30, 2019
@victorporof
Allow cc to handle build optimizations
10751ee 
Fixes #54

Signed-off-by: Victor Porof <victor.porof@gmail.com>
@victorporof victorporof mentioned this issue Aug 30, 2019
Merged
victorporof added a commit that referenced this issue Sep 4, 2019
@victorporof
Allow cc to handle build optimizations
6ddd81f 
Fixes #54

Signed-off-by: Victor Porof <victor.porof@gmail.com>
victorporof added a commit that referenced this issue Sep 4, 2019
@victorporof
Allow cc to handle build optimizations
2089925 
Fixes #54

Signed-off-by: Victor Porof <victor.porof@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update lmdb to latest version and other goodies mozilla/lmdb-rs
1 participant
@mykmelez