Skip to content
This repository has been archived by the owner on Dec 1, 2017. It is now read-only.

Bug 1292099 - Disable FF Hello from running in FF 49 or later. #584

Merged
merged 1 commit into from Aug 15, 2016

Conversation

Standard8
Copy link
Member

Simple change to not start Hello for FF 49 or later (i.e. no button nor anything else) - primarily just for posting to AMO for the beta add-on. We'll do an uninstall itself once we stop running Hello completely.

// Anything later than FF 49 we don't support, so don't try to display the
// button. Later this will be to uninstall the add-on itself.
// Note: this check exists in shutdown() as well.
Cu.reportError(Services.appinfo.version);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is reportError the right thing to use here? Should there be a more detailed message here so people know where this message comes from?

@Standard8 Standard8 merged commit 7a0f4bf into master Aug 15, 2016
@Standard8 Standard8 deleted the remove-button-49 branch August 15, 2016 17:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants