Skip to content

change page names and fix tests #32

Merged
merged 2 commits into from Jun 6, 2012

3 participants

@bebef1987
Mozilla member

Some pages have changed and I made the necessary changes in our repo
also fixed the login issue using the method from http://code.google.com/p/selenium/issues/detail?id=4027
I hope this is a temporary fix

@stephendonner stephendonner and 1 other commented on an outdated diff Jun 6, 2012
pages/desktop/developer_hub/home.py
- def go_to_homepage(self):
- self.selenium.get(self.base_url)
+ _page_title = "Developers| Mozilla Marketplace"
@stephendonner
stephendonner added a note Jun 6, 2012

Does this pass? The spacing isn't right - there should be a space after "Developers" and before the pipe char.

@bebef1987
Mozilla member
bebef1987 added a note Jun 6, 2012

hmmm... don't know what happen there. Added the space :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@stephendonner stephendonner and 1 other commented on an outdated diff Jun 6, 2012
tests/desktop/test_developer_hub.py
- submited_app_names = [app.name for app in dev_hub.submited_apps]
+ submited_app_names = [app.name for app in dev_submissions.submited_apps]
@stephendonner
stephendonner added a note Jun 6, 2012

s/submited_app_names/submitted_app_names, ditto for:

s/submited_apps

@bebef1987
Mozilla member
bebef1987 added a note Jun 6, 2012

updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@stephendonner stephendonner and 1 other commented on an outdated diff Jun 6, 2012
tests/desktop/test_developer_hub.py
incomplete_apps = False
import time
previous_app_date = time.gmtime()
- while not dev_hub.paginator.is_next_page_disabled:
- for app in dev_hub.submited_apps:
+ while not dev_submissions.paginator.is_next_page_disabled:
+ for app in dev_submissions.submited_apps:
@stephendonner
stephendonner added a note Jun 6, 2012

s/submited_apps/submitted_apps

@bebef1987
Mozilla member
bebef1987 added a note Jun 6, 2012

updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@stephendonner

Which test(s) is this pull request intended to fix? Is it test_that_checks_apps_are_sorted_by_name?

@klrmn
klrmn commented Jun 6, 2012

LGTM

@klrmn klrmn merged commit c7b841d into mozilla:master Jun 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.