Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Adding tests for /firefox/all page #140

Merged
merged 1 commit into from Nov 7, 2012

Conversation

Projects
None yet
3 participants
Member

retornam commented Nov 7, 2012

Test for /firefox/all/page

@retornam retornam referenced this pull request Nov 7, 2012

Closed

Check lang links #133

Collaborator

bobsilverberg commented Nov 7, 2012

LGTM and the test passes. It does take quite a long time though. I wonder if it would be worthwhile using a similar technique to https://github.com/mozilla/mcom-tests/blob/master/tests/test_download.py rather than using Selenium?

Collaborator

stephendonner commented Nov 7, 2012

How much extra run time does this add to the suite? I, too, was envisioning something along the lines of test_download.py, but am obviously not the best to judge the technical and coverage/maintainability merits of both :-)

Collaborator

bobsilverberg commented Nov 7, 2012

The test takes around 150 seconds to complete for me, but now that I think about it, most of that time is likely spent checking response codes. I don't know that a Selenium-less approach would reduce that by much.

Member

retornam commented Nov 7, 2012

Using a selenium-less approach would take about the same time since I would have to use beautifulsoup to scrape the page then check for response codes using requests. I'm open to suggestions

Collaborator

bobsilverberg commented Nov 7, 2012

All agreed it's good how it is. Merging.

@bobsilverberg bobsilverberg added a commit that referenced this pull request Nov 7, 2012

@bobsilverberg bobsilverberg Merge pull request #140 from retornam/locales
Adding tests for /firefox/all page
83a2ec4

@bobsilverberg bobsilverberg merged commit 83a2ec4 into mozilla:master Nov 7, 2012

@retornam retornam deleted the retornam:locales branch Jan 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment