Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Updating requests from 0.11.1 to 1.2.0 #174

Merged
merged 1 commit into from Apr 1, 2013

Conversation

Projects
None yet
3 participants
Member

retornam commented Apr 1, 2013

We are 22 versions behind on the requests module. The current version of the modules removes the config keyword argument which we use to set the max_retries parameter. We can set the max_retries by setting the default retries to 5 in requests.adapters .
requests.adapters.DEFAULT_RETRIES = 5

@retornam retornam Updating requests from 0.11.1 to 1.2.0, setting max_retries in page.p…
…y since config is no longer used in requests.get
613af03
Collaborator

bobsilverberg commented Apr 1, 2013

LGTM and tests pass. r+

Should we be thinking about this upgrade for other projects too?

Member

retornam commented Apr 1, 2013

@bobsilverberg yes we should. I'll go through all the projects and submit an update

Collaborator

stephendonner commented Apr 1, 2013

Explicit r+ from Bob, so merging. Thanks, you two!

@stephendonner stephendonner added a commit that referenced this pull request Apr 1, 2013

@stephendonner stephendonner Merge pull request #174 from retornam/upgraderequests
Updating requests from 0.11.1 to 1.2.0
83f4f8c

@stephendonner stephendonner merged commit 83f4f8c into mozilla:master Apr 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment