Skip to content
Browse files

Changing is_search_visible to is_search_present

The BrowserID button on http://developer.mozilla.org displays a message to
users which covers the search button and causes the is_element_visible
function to fail. Switching to is_element_present fixes this.
  • Loading branch information...
1 parent 09bcce0 commit 1e5abf0e1d54b3f5a0fd29e6f2fca3b4ba2794c7 @retornam retornam committed Jun 8, 2012
Showing with 6 additions and 6 deletions.
  1. +2 −2 pages/base.py
  2. +1 −1 tests/test_demo.py
  3. +1 −1 tests/test_dev_derby.py
  4. +1 −1 tests/test_home.py
  5. +1 −1 tests/test_learning.py
View
4 pages/base.py
@@ -81,8 +81,8 @@ def click_profile_link(self):
return ProfilePage(self.testsetup)
@property
- def is_search_visible(self):
- return self.is_element_visible(self._search_locator)
+ def is_search_present(self):
+ return self.is_element_present(self._search_locator)
@property
def browser_id_info(self):
View
2 tests/test_demo.py
@@ -23,7 +23,7 @@ def test_header_links(self, mozwebqa):
Assert.true(demo_pg.header.is_demos_link_visible)
Assert.true(demo_pg.header.is_learning_link_visible)
Assert.true(demo_pg.header.is_community_link_visible)
- Assert.true(demo_pg.header.is_search_visible)
+ Assert.true(demo_pg.header.is_search_present)
@pytest.mark.nondestructive
def test_footer_links(self, mozwebqa):
View
2 tests/test_dev_derby.py
@@ -21,7 +21,7 @@ def test_header_links(self, mozwebqa):
Assert.true(derby_pg.header.is_demos_link_visible)
Assert.true(derby_pg.header.is_learning_link_visible)
Assert.true(derby_pg.header.is_community_link_visible)
- Assert.true(derby_pg.header.is_search_visible)
+ Assert.true(derby_pg.header.is_search_present)
@pytest.mark.nondestructive
def test_are_footer_links_visible(self, mozwebqa):
View
2 tests/test_home.py
@@ -21,7 +21,7 @@ def test_header_links(self, mozwebqa):
Assert.true(home_pg.header.is_demos_link_visible)
Assert.true(home_pg.header.is_learning_link_visible)
Assert.true(home_pg.header.is_community_link_visible)
- Assert.true(home_pg.header.is_search_visible)
+ Assert.true(home_pg.header.is_search_present)
@pytest.mark.nondestructive
def test_footer_links(self, mozwebqa):
View
2 tests/test_learning.py
@@ -32,7 +32,7 @@ def test_header_links_visible(self, mozwebqa):
Assert.true(learning_pg.header.is_demos_link_visible)
Assert.true(learning_pg.header.is_learning_link_visible)
Assert.true(learning_pg.header.is_community_link_visible)
- Assert.true(learning_pg.header.is_search_visible)
+ Assert.true(learning_pg.header.is_search_present)
@pytest.mark.nondestructive
def test_page_elements_are_visible(self, mozwebqa):

0 comments on commit 1e5abf0

Please sign in to comment.
Something went wrong with that request. Please try again.