Got a clash of key names while trying to run update.php #16

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
3 participants
@hexmode
Contributor

hexmode commented Jan 22, 2013

The name "key_unique" surprisingly isn't that unique.

+ $this->expire( $key );
+ return;
+ }
+

This comment has been minimized.

Show comment Hide comment
@brandonsavage

brandonsavage Jan 23, 2013

Collaborator

What is the reason for this particular change?

@brandonsavage

brandonsavage Jan 23, 2013

Collaborator

What is the reason for this particular change?

This comment has been minimized.

Show comment Hide comment
@hexmode

hexmode Jan 23, 2013

Contributor

Sorry, my ignorance of how github handles pull requests bit me here. This was supposed to be separate.

@hexmode

hexmode Jan 23, 2013

Contributor

Sorry, my ignorance of how github handles pull requests bit me here. This was supposed to be separate.

@brandonsavage

This comment has been minimized.

Show comment Hide comment
@brandonsavage

brandonsavage Feb 3, 2013

Collaborator

Here's what I'll ask you to do: cherry-pick your commits into two branches, submit two pull requests for those two branches. That way each commit is atomic.

Collaborator

brandonsavage commented Feb 3, 2013

Here's what I'll ask you to do: cherry-pick your commits into two branches, submit two pull requests for those two branches. That way each commit is atomic.

@reedy

This comment has been minimized.

Show comment Hide comment
@reedy

reedy Mar 30, 2013

Contributor

I'll see about re-doing these over the weekend so we can get them merged

Contributor

reedy commented Mar 30, 2013

I'll see about re-doing these over the weekend so we can get them merged

@brandonsavage

This comment has been minimized.

Show comment Hide comment
@brandonsavage

brandonsavage Apr 4, 2013

Collaborator

This PR cannot automatically be merged. R- and closing until they can be resubmitted.

Collaborator

brandonsavage commented Apr 4, 2013

This PR cannot automatically be merged. R- and closing until they can be resubmitted.

@reedy

This comment has been minimized.

Show comment Hide comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment