Improving the caching mechanism, in preparation for providing a memcache... #9

Merged
merged 5 commits into from Dec 11, 2012

Projects

None yet

3 participants

Collaborator

... option for IT to utilize in production.

Collaborator

Is anybody ever going to review this pull request?

Contributor

Can't test it right now, but it makes sense.

I will need to resubmit my own postgresql/sqlite branch after this one makes it through.

Member
adngdb commented Aug 21, 2012

Both memcache and apc cache work, we now need the MySQL cache to work and this is going in.

For information, there is an unserialize error with the MySQL cache, Brandon is working on it.

Collaborator

Adrian, I believe the MySQL cache errors are fixed. Can you retest?

@adngdb adngdb commented on an outdated diff Sep 28, 2012
cache/BugzillaCacheMysql.class.php
+ 'bugzilla_cache',
+ array(
+ '`key`' => $key_c,
+ 'fetched_at' => $date,
+ 'data' => $value_c,
+ 'expires' => $expires
+ ),
+ __METHOD__
+ );
+ } else {
+ $res = $this->update(
+ 'bugzilla_cache',
+ array(
+ 'fetched_at' => $date
+ ),
+ 'key = "' . $key_c . '"',
adngdb
adngdb Sep 28, 2012 Member

Don't you need to add some quotes here as well?

adngdb
adngdb Sep 28, 2012 Member

Around the keyword key I mean.

@brandonsavage brandonsavage merged commit 7ba55fd into mozilla:master Dec 11, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment