Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Upgrade widget and panel communication to use "postMessage" instead the "port" object. #185

Closed
xabolcs opened this Issue · 3 comments

2 participants

@xabolcs
Collaborator

From #183:

xabolcs commented a day ago:

[...]
The other main task in this issue is to upgrade the communication from port based to message based.

whimboo commented 5 hours ago

I wonder if we should do the change from port to message first in another pull. I don't think that this is related to Australis, and we might be able to get this done earlier. Since when we have message support? Goes it back to Firefox 24?

@whimboo whimboo added this to the 0.6 milestone
@whimboo
Collaborator

This issue will be part of the next 0.6 release of Memchaser.

@xabolcs
Collaborator

Ohh, I forgot open a pull request for this.

@xabolcs xabolcs referenced this issue from a commit in xabolcs/memchaser
@xabolcs xabolcs Issue #185 - Code styling 958ce23
@xabolcs xabolcs referenced this issue from a commit in xabolcs/memchaser
@xabolcs xabolcs Issue #185 - postMessage "*" in contextPanel 9589ed4
@xabolcs xabolcs referenced this issue from a commit in xabolcs/memchaser
@xabolcs xabolcs Issue #185 - Fix undefined data 951978a
@xabolcs xabolcs referenced this issue from a commit in xabolcs/memchaser
@xabolcs xabolcs Issue #185 - Color message topics f06a631
@xabolcs xabolcs referenced this issue from a commit in xabolcs/memchaser
@xabolcs xabolcs Issue #185 - Color "type" in context.js too 91f57fe
@xabolcs xabolcs referenced this issue from a commit in xabolcs/memchaser
@xabolcs xabolcs Issue #185 - Remove unused target parameter in postMessage 7f825e5
@xabolcs xabolcs referenced this issue from a commit in xabolcs/memchaser
@xabolcs xabolcs Issue #185 - postmessage({data: ..., type: ...}) (almsost?) everywher…
…e but dead object occurs
40790ff
@xabolcs xabolcs referenced this issue from a commit in xabolcs/memchaser
@xabolcs xabolcs Issue #185 - let { type, data } = aMessage; everywhere, nits 1362841
@xabolcs xabolcs referenced this issue from a commit in xabolcs/memchaser
@xabolcs xabolcs Issue #185 - console.error: memchaser:
  Message: ReferenceError: aMessage is not defined
  Stack:
    exports.main/<@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///home/szab/mozilla/profiles/fxdefault/extensions/memchaser@quality.mozilla.org.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://memchaser-at-quality-dot-mozilla-dot-org/memchaser/lib/main.js:102:1
604c1dc
@whimboo
Collaborator

PR #186 has been merged. Thank you a lot for this work @xabolcs!

@whimboo whimboo closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.