Avoid Fixed width Layout, Prefer em to px as Fallback #85

Closed
anon-user opened this Issue Mar 11, 2012 · 9 comments

Projects

None yet

4 participants

@anon-user

Memchaser 0.2 uses:
toolbaritem style="min-width: 360px;"
iframe style="width: 360px;"

However, given that I have a smaller font size, this leaves a significant blank space to the left.
For other users, this may cause hidden overflow...

If you MUST force the width, try something like '22em;' instead, which will scale with font size.

Better yet, avoid a fixed width layout entirely!

@whimboo

We are still blocked on https://bugzilla.mozilla.org/show_bug.cgi?id=645506 for a real flexible solution. Until this has been solved I would happily take a fix for em, which should indeed make it better for different font sizes.

@dglol

I don't think a fix for em would work. The widget width option currently only supports numbers and the px concatenation is built in:

https://github.com/mozilla/addon-sdk/blob/master/packages/addon-kit/lib/widget.js#L68-69
https://github.com/mozilla/addon-sdk/blob/master/packages/addon-kit/lib/widget.js#L675-677

@whimboo

David, do you mind filing a bug for it on Bugzilla or talk to Alex Pirot on IRC if something like that would be wanted in the Add-on SDK?

@dglol

Sure, will do.

@dglol

Bug is here: https://bugzilla.mozilla.org/show_bug.cgi?id=737170

I also investigated if dynamic width layouts are possible. They are doable but it introduces an UX issue which is that widgets will move with the width change. The most elegant solution is to introduce a field in the preferences to change the width (which can be used in the configuration panel).

@whimboo

Thanks David for the investigation. I think it's enough to have the em support for now. Given the future plans of the SDK which will put the widgets in the navigation bar, gives a totally different behavior. I don't have the link to the UX mockups handy but there was a blog post about it recently if you are curious.

@whimboo

As long as we are blocked by an SDK bug we can't schedule it for one of our own releases. Removing it from 0.3 milestone.

@xabolcs

Wontfix, isn't it?

@whimboo

Jepp, there are no hard-coded width anymore.

@whimboo whimboo closed this Jun 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment