Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Repository: Switch to AddonSDK release branch (#154) #154

Merged
merged 1 commit into from

2 participants

@whimboo
Collaborator

No description provided.

@whimboo
Collaborator

@davehunt, this pull is waiting for your review for 2 weeks now. Would you mind checking it? Thanks

@davehunt
Owner

@whimboo If you specifically want me to review something it's best to either assign it to me or to mention me in a comment (or ping me on IRC). I will get to this today.

@davehunt davehunt was assigned
@whimboo
Collaborator

We don't have any other reviewer for memchaser. So you should always count on it to be the reviewer.

@davehunt
Owner

Looks good, and tests passing for me.

@davehunt
Owner

We don't have any other reviewer for memchaser. So you should always count on it to be the reviewer.

I would still appreciate an initial review request rather than a comment that it's been left for 2 weeks. Thanks.

@whimboo
Collaborator

Then you should do the same if you want to get something reviewed from me (also for other projects). :)

@whimboo whimboo merged commit 5800b71 into mozilla:master

1 check passed

Details default The Travis build passed
@davehunt
Owner

Then you should do the same if you want to get something reviewed from me (also for other projects). :)

This is already understood. I normally ping you on IRC with regards to patches that only you can review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  addon-sdk
2  addon-sdk
@@ -1 +1 @@
-Subproject commit 4dfc2b654725e382eaa7b8a53b6910d2bb05f52f
+Subproject commit 176d82da5b7de5c27c8fd50bc9fa7b053eda5412
Something went wrong with that request. Please try again.