Repository: Switch to AddonSDK release branch (#154) #154

Merged
merged 1 commit into from Nov 19, 2012

Projects

None yet

2 participants

@whimboo
Contributor
whimboo commented Nov 6, 2012

No description provided.

@whimboo
Contributor
whimboo commented Nov 19, 2012

@davehunt, this pull is waiting for your review for 2 weeks now. Would you mind checking it? Thanks

@davehunt
Member

@whimboo If you specifically want me to review something it's best to either assign it to me or to mention me in a comment (or ping me on IRC). I will get to this today.

@davehunt davehunt was assigned Nov 19, 2012
@whimboo
Contributor
whimboo commented Nov 19, 2012

We don't have any other reviewer for memchaser. So you should always count on it to be the reviewer.

@davehunt
Member

Looks good, and tests passing for me.

@davehunt
Member

We don't have any other reviewer for memchaser. So you should always count on it to be the reviewer.

I would still appreciate an initial review request rather than a comment that it's been left for 2 weeks. Thanks.

@whimboo
Contributor
whimboo commented Nov 19, 2012

Then you should do the same if you want to get something reviewed from me (also for other projects). :)

@whimboo whimboo merged commit 5800b71 into mozilla:master Nov 19, 2012

1 check passed

default The Travis build passed
Details
@davehunt
Member

Then you should do the same if you want to get something reviewed from me (also for other projects). :)

This is already understood. I normally ping you on IRC with regards to patches that only you can review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment