This repository has been archived by the owner on Oct 28, 2022. It is now read-only.
Remove test-ci image from docker-compose configuration #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test-ci image makes it impossible to bring up the docker-compose environment locally, since it conflicts with the "web" image. Instead, let's just run the tests inside the web image itself. All of this is only relevant inside the circle environment. (note that this change removes the code to call codecov, but that was not active anyway)
|
@whd could you double check this? I noticed this when trying to debug some mission control stuff locally. |
|
On testing, this isn't going to work properly. So frustrating. Going to try another approach, sorry for the noise. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test-ci image makes it impossible to bring up the docker-compose
environment locally, since it conflicts with the "web" image. Instead,
let's just run the tests inside the web image itself. All of this
is only relevant inside the circle environment.
(note that this change removes the code to call codecov, but that
was not active anyway)