Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new command to check backfills completion on last pushes #736

Merged
merged 4 commits into from May 6, 2022
Merged

Add a new command to check backfills completion on last pushes #736

merged 4 commits into from May 6, 2022

Conversation

EvaBardou
Copy link
Collaborator

Closes #728

@EvaBardou EvaBardou requested a review from La0 April 27, 2022 15:34
@EvaBardou EvaBardou self-assigned this Apr 27, 2022
@EvaBardou EvaBardou marked this pull request as draft April 27, 2022 15:34
La0
La0 suggested changes May 2, 2022
View reviewed changes
mozci/util/taskcluster.py Outdated Show resolved Hide resolved
mozci/util/taskcluster.py Outdated Show resolved Hide resolved
mozci/util/taskcluster.py Outdated Show resolved Hide resolved
mozci/console/commands/push.py Outdated Show resolved Hide resolved
mozci/console/commands/push.py Outdated Show resolved Hide resolved
mozci/console/commands/push.py Outdated Show resolved Hide resolved
mozci/console/commands/push.py Outdated Show resolved Hide resolved
mozci/console/commands/push.py Outdated Show resolved Hide resolved
mozci/console/commands/push.py Outdated Show resolved Hide resolved
mozci/console/commands/push.py Outdated Show resolved Hide resolved
La0
La0 reviewed May 2, 2022
View reviewed changes
mozci/console/commands/push.py Outdated Show resolved Hide resolved
La0
La0 reviewed May 2, 2022
View reviewed changes
mozci/console/commands/push.py Outdated Show resolved Hide resolved
mozci/console/commands/push.py Outdated Show resolved Hide resolved
@La0
Copy link
Contributor

La0 commented May 4, 2022

As discussed with @marco-c, please update the command to expose it at root level (as mozci check-backfills)

@EvaBardou EvaBardou force-pushed the notify-backfill-group-completion branch from 5479b14 to b33e56a Compare May 4, 2022 15:34
@EvaBardou EvaBardou requested review from La0 and marco-c May 4, 2022 15:34
@EvaBardou EvaBardou requested a review from marco-c May 5, 2022 09:29
@marco-c marco-c marked this pull request as ready for review May 5, 2022 10:13
@marco-c
Copy link
Collaborator

marco-c commented May 5, 2022

@La0 we can merge this if you're OK with the latest iteration of the patch.

La0
La0 approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@La0 La0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code & output are way better 💯

@La0 La0 merged commit b0b236d into mozilla:master May 6, 2022
@EvaBardou EvaBardou deleted the notify-backfill-group-completion branch June 23, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Archaeopteryx Archaeopteryx Archaeopteryx left review comments

@La0 La0 La0 approved these changes

@marco-c marco-c marco-c approved these changes

Assignees

@EvaBardou EvaBardou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Send a notification in the Matrix channel when a backfill is finished
4 participants
@EvaBardou @La0 @marco-c @Archaeopteryx