Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Don't enable retries by default #65

Closed
whimboo opened this Issue Apr 9, 2013 · 2 comments

Comments

Projects
None yet
2 participants
Contributor

whimboo commented Apr 9, 2013

I think I have mentioned it before on the original implementation bug and I'm still not a fan of having this enabled by default. I don't think that this gives 90% of our users a benefit given that they will never reach the situation that a build they want to download is not available but 20s later. This is really only the case for our Mozmill CI which tries to start a download as soon as the build notifications come through. Also I believe that the pulsebuildmonitor inclusion which currently happens will invalidate it for CI because builds should really be up at this time.

So Mozmill CI should be updated to use the optional command line option of mozdownload to specify the retries and timeouts. We should not cause headaches by the user if a wrong version or such has been specified. Retries will not help at all in those situations.

Member

davehunt commented Apr 9, 2013

I'm in favour of this being enabled by default, but don't feel strongly enough to object to this change.

Contributor

whimboo commented Apr 10, 2013

Seeing were our tool is used so far, the automation piece is only a small fraction of it. None of those other requests will be so close to the publish of a build on the FTP server. And given that defaults are for the majority it would be the right step to go.

@whimboo whimboo closed this Apr 22, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment