Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

don't require Windows daily builds to have '.installer' in their names #49

Closed
wants to merge 1 commit into from

3 participants

@mykmelez
Owner

@whimboo: This is the separate pull request that reverts a change you made in pull 31 that broke downloading of Windows B2G builds, which don't have an installer variant.

See for example this directory containing the most recent Windows build:

https://ftp.mozilla.org/pub/mozilla.org/b2g/nightly/2012/12/2012-12-13-09-53-19-mozilla-b2g18/

Presumably you made the change for a reason, though, and I don't want to break that other use case! Perhaps you can elaborate, and then we can figure out how to keep both working?

@whimboo
Owner

We cannot revert this change because we would download the stub installer instead. To fix that we might need code which will fix #29 at the same time.

@whimboo
Owner

@mykmelez would you have the time to check the stub installer stuff? If not I will have to see when I can have a look at.

@Nebelhom
Collaborator

This looks pretty much like the issue we're trying to fix in #104 ( #113 )

@whimboo

can we close this and refer it to the aforementioned issue?

@whimboo
Owner

Would make sense, yes.

@whimboo whimboo closed this
@mykmelez mykmelez deleted the mykmelez:installer-in-name branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +2 −2 mozdownload/scraper.py
View
4 mozdownload/scraper.py
@@ -287,8 +287,8 @@ def binary_regex(self):
'linux64': r'\.%(EXT)s$',
'mac': r'\.%(EXT)s$',
'mac64': r'\.%(EXT)s$',
- 'win32': r'(\.installer)\.%(EXT)s$',
- 'win64': r'(\.installer)\.%(EXT)s$'}
+ 'win32': r'(\.installer)?\.%(EXT)s$',
+ 'win64': r'(\.installer)?\.%(EXT)s$'}
regex = regex_base_name + regex_suffix[self.platform]
return regex % {'APP': self.application,
Something went wrong with that request. Please try again.