Bug 717121 - crash nsMIMEHeaderParamImpl::DoParameterInternal. r=bz,a…

…=Standard8 for checkin to Thunderbird/SeaMonkey specific relbrach and CLOSED TREE --HG-- branch : COMM1001_2012020813_RELBRANCH extra : transplant_source : f%FCe%148%E7%A3yv%A5%7F%D6%E2%E7%C3%07%B5%D0fm
mozilla · Feb 3, 2012 · 5745156 · 5745156
1 parent da13fce
commit 5745156
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/netwerk/mime/nsMIMEHeaderParamImpl.cpp b/netwerk/mime/nsMIMEHeaderParamImpl.cpp
@@ -308,7 +308,10 @@ nsMIMEHeaderParamImpl::DoParameterInternal(const char *aHeaderValue,
         else if (*valueEnd == '"')
           break;
       }
-      str = valueEnd + 1;
+      str = valueEnd;
+      // *valueEnd != null means that *valueEnd is quote character.
+      if (*valueEnd)
+        str++;
     }
 
     // See if this is the simplest case (case A above),

diff --git a/netwerk/test/unit/test_MIME_params.js b/netwerk/test/unit/test_MIME_params.js
@@ -296,6 +296,11 @@ var tests = [
 
   ["attachment; filename*=\"a%20b\"", 
    "attachment", "a b"],
+
+  // Bug 717121: crash nsMIMEHeaderParamImpl::DoParameterInternal
+
+  ["attachment; filename=\"", 
+   "attachment", ""], 
 ];
 
 function do_tests(whichRFC)