Support multilingual slides #12

Merged
merged 3 commits into from Aug 13, 2015

Conversation

Projects
None yet
3 participants
@nth10sd

nth10sd commented Aug 13, 2015

I have added support for multilingual slides. By choosing the desired language option, the slides that have content within the respective language class names (e.g. "en-US" and "zh-TW") will switch between them.

The language change is persistent across slides, and in Firefox, the URL bar will update the lang attribute as well.

In this pull request, only the 2nd and 3rd (shout slide) slides have multilingual content as an example.

Credits to :MattN for greatly helping me out throughout.

@nth10sd

This comment has been minimized.

Show comment
Hide comment
@nth10sd

nth10sd Aug 13, 2015

Rev a032ef3 is needed to allow the updating of the URL bar.

nth10sd commented Aug 13, 2015

Rev a032ef3 is needed to allow the updating of the URL bar.

@Ms2ger

This comment has been minimized.

Show comment
Hide comment
@Ms2ger

Ms2ger Aug 13, 2015

Why classes rather than lang?

Ms2ger commented Aug 13, 2015

Why classes rather than lang?

codepo8 added a commit that referenced this pull request Aug 13, 2015

Merge pull request #12 from nth10sd/master
Support multilingual slides

@codepo8 codepo8 merged commit adbd3a2 into mozilla:master Aug 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment