Clarify where data in UserProfileAdmin comes from. #262

Merged
merged 1 commit into from Jun 14, 2012

Conversation

Projects
None yet
2 participants
Member

jsocol commented Jun 14, 2012

Makes callables on the UserProfile model look distinct from typical
double-underscore lookups. Different options on ModelAdmin behave
differently, so this should make it clearer which option is using which
data source.

This partially reverts c957841 but should keep the same functionality.

Clarify where data in UserProfileAdmin comes from.
Makes callables on the UserProfile model look distinct from typical
double-underscore lookups. Different options on ModelAdmin behave
differently, so this should make it clearer which option is using which
data source.
Contributor

readevalprint commented Jun 14, 2012

looks

Contributor

readevalprint commented Jun 14, 2012

Yes this is good. r+

Contributor

readevalprint commented Jun 14, 2012

Should there be a bug for this?

Member

jsocol commented Jun 14, 2012

It's immediate clean-up and qa-, I think we can skip the bug here.

----- Original Message -----
From: Tim Watts reply@reply.github.com
To: James Socol james@mozilla.com
Sent: Thu, 14 Jun 2012 10:37:22 -0700 (PDT)
Subject: Re: [mozillians] Clarify where data in UserProfileAdmin comes from. (#262)

Should there be a bug for this?


Reply to this email directly or view it on GitHub:
#262 (comment)

readevalprint added a commit that referenced this pull request Jun 14, 2012

Merge pull request #262 from jsocol/admin-clarity
Clarify where data in UserProfileAdmin comes from.

@readevalprint readevalprint merged commit 42117ee into mozilla:master Jun 14, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment