Skip to content

[Fix Bug 972466]: updated HTML for Submit changes and Create Group buttons #843

Closed
wants to merge 4 commits into from

2 participants

@chefscott

Updated HTML to render button styles that matched the rest of the Groups buttons.

@glogiotatidis
Mozilla member

@chefscott Thank you for your pull request. Did you setup your environment and try that locally? If you want help to set it up you can ping us on IRC.

@chefscott

My environment is setup -- is it rendering correctly on your side?

@glogiotatidis
Mozilla member

Hi @chefscott . No it's not rendering correctly on my side. You have typos in the code you send so that's expected :)

@chefscott

Sorry about that. It should render correctly now.

@glogiotatidis
Mozilla member

OK this is working fine now. A couple of changes:

Sarah McSarah added some commits Mar 5, 2014
Sarah McSarah Bug 972466: Submit HTML changes for Create Group buttons
Fixed typo.

Added back id
8c9e443
Sarah McSarah Fixed merge 33321db
@glogiotatidis
Mozilla member

Ouch that squash didn't go well :) I'll help you with that, it can be painful.

@glogiotatidis
Mozilla member

OK I rebased this properly and merged here. c0429ed

Thanks @chefscott ! r+ 🍰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.