Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

[Fix Bug 972466]: updated HTML for Submit changes and Create Group buttons #843

Closed
wants to merge 4 commits into from

2 participants

@chefscott

Updated HTML to render button styles that matched the rest of the Groups buttons.

@glogiotatidis

@chefscott Thank you for your pull request. Did you setup your environment and try that locally? If you want help to set it up you can ping us on IRC.

@chefscott

My environment is setup -- is it rendering correctly on your side?

@glogiotatidis

Hi @chefscott . No it's not rendering correctly on my side. You have typos in the code you send so that's expected :)

@chefscott

Sorry about that. It should render correctly now.

@glogiotatidis

OK this is working fine now. A couple of changes:

Sarah McSarah added some commits
Sarah McSarah Bug 972466: Submit HTML changes for Create Group buttons
Fixed typo.

Added back id
8c9e443
Sarah McSarah Fixed merge 33321db
@glogiotatidis

Ouch that squash didn't go well :) I'll help you with that, it can be painful.

@glogiotatidis

OK I rebased this properly and merged here. c0429ed

Thanks @chefscott ! r+ :cake:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 6, 2014
Commits on Mar 11, 2014
  1. @chefscott

    Fixed typo.

    chefscott authored
Commits on Mar 12, 2014
  1. Bug 972466: Submit HTML changes for Create Group buttons

    Sarah McSarah authored
    Fixed typo.
    
    Added back id
  2. Fixed merge

    Sarah McSarah authored
This page is out of date. Refresh to see the latest.
Showing with 3 additions and 2 deletions.
  1. +3 −2 mozillians/templates/groups/add_edit.html
View
5 mozillians/templates/groups/add_edit.html
@@ -87,9 +87,10 @@
<fieldset id="edit_controls">
{% if creating %}
- <button id="create_group_button" type="submit">{{ _('Create Group') }}</button>
+<<<<<<< HEAD
+ <button id="create_group_button" class="button" type="submit">{{ _('Create Group') }}</button>
{% else %}
- <button id="submit_changes_button" type="submit">{{ _('Submit changes') }}</button>
+ <button id="submit_changes_button" class="button" type="submit">{{ _('Submit changes') }}</button>
{% endif %}
</fieldset>
Something went wrong with that request. Please try again.