Skip to content

[fix bug 973387] Allow curators to change accepting_new_members field. #846

Merged
merged 1 commit into from Mar 17, 2014

2 participants

@glogiotatidis
Mozilla member

No description provided.

@glogiotatidis
Mozilla member
@dpoirier dpoirier commented on the diff Mar 6, 2014
mozillians/groups/tests/test_forms.py
@@ -13,11 +13,9 @@ def test_name_unique(self):
ok_(not form.is_valid())
ok_('name' in form.errors)
-
-class SuperuserGroupFormTests(TestCase):
def test_by_request_group_without_new_member_criteria(self):
@dpoirier
dpoirier added a note Mar 6, 2014

This leaves us without any tests for SuperuserGroupForm. We might at least want a subclass of GroupFormTests that runs the same tests, against SuperuserGroupForm instead of GroupForm?

@glogiotatidis
Mozilla member
glogiotatidis added a note Mar 6, 2014

Well we just inherit GroupForm so maybe it's ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@dpoirier

r+

@glogiotatidis
Mozilla member

thanks!

@glogiotatidis glogiotatidis merged commit 339e9b2 into mozilla:master Mar 17, 2014

1 check passed

Details default Jenkins build 'mozillians_github' #1273 has succeeded
@glogiotatidis glogiotatidis deleted the glogiotatidis:973387 branch Jun 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.