Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

WIP - Bug 931359 #848

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@ghost

ghost commented Mar 9, 2014

Based on @bharaththiruveedula's work.

@ghost

ghost commented Mar 10, 2014

OKay, i must broke html tags during commit. Sorry for that i'll post update later.

Member

glogiotatidis commented Mar 11, 2014

@jarekps When you update the code, ping me here to look at it. thanks!

bharaththiruveedula and others added some commits Oct 29, 2013

@bharaththiruveedula bharaththiruveedula [fix Bug 931359]Adds vouchees info to the profile page
Conflicts:
	mozillians/phonebook/views.py
	mozillians/templates/phonebook/profile.html
d4b57d1
Jarek 'jarekps' Smiejczak Bug 931359 - added vouched profiles field with privacy support. 5200a42
@ghost

ghost commented Mar 11, 2014

@giogiotatidis please look again :)

Member

glogiotatidis commented Mar 14, 2014

@jarekps Continuing yesterday's discussion on IRC:

if attrname == vouchees:
        blah blah blah

This can be complicated so don't hesitate to ask me here or ping me on IRC to discuss this further.

Thanks!

Member

glogiotatidis commented Mar 14, 2014

Update:
You can go ahead and use the def vouched_profiles(self): method you created (I just noticed that). But instead of checking the vouched_by value, you should be checking whether the vouchee profile has any attribute available in the current privacy level similar to the way we do it here

https://github.com/mozilla/mozillians/blob/master/mozillians/users/models.py#L242

Member

glogiotatidis commented Mar 24, 2014

@jarekps how is this going? Don't hesitate to ping me for help when / if needed. :)

@glogiotatidis glogiotatidis changed the title from Bug 931359 to WIP - Bug 931359 Mar 26, 2014

@ghost

ghost commented Mar 31, 2014

@glogiotatidis sorry, but i'm currently a little to busy to continue work on this patch :( Please feel free to pass this issue for somebody else.

Member

glogiotatidis commented Apr 1, 2014

@jarekps :( Thanks for your work. Please come back when you have more time :)

Member

glogiotatidis commented Apr 11, 2014

Closing this one for now. I'll post a new complete one next week.

Thanks @jarekps !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment