Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about silent ABI break to relese notes for 2.0 #67

Closed
dwbuiten opened this issue Jul 15, 2014 · 6 comments
Closed

Add note about silent ABI break to relese notes for 2.0 #67

dwbuiten opened this issue Jul 15, 2014 · 6 comments

Comments

@dwbuiten
Copy link
Member

@dwbuiten dwbuiten commented Jul 15, 2014

You did not mention this at all in the release notes. You have broken the ABI without bumping the SONAME, and it is incredibly irresponsible to not mention this upfront and center in the release notes.

@bdaehlie
Copy link
Member

@bdaehlie bdaehlie commented Jul 15, 2014

Issue 21 covers our discussion about ABI compatibility. We should make a decision about what we want to do soon. We should do a better job noting our ABI break in the mean time, I agree.

@dwbuiten
Copy link
Member Author

@dwbuiten dwbuiten commented Jul 15, 2014

@bdaehlie This is specific to 2.0 though, it's not just "ABI".

@dwbuiten
Copy link
Member Author

@dwbuiten dwbuiten commented Jul 16, 2014

FYI, v2.0.1 does nothing to address the SOname issue. You are still naming yourself libjpeg.so, and presenting yourself as the jpeg6 ABI by your SOname. The jpeg6 ABI has more than a decade of history, and the ABI itself is a requirement for e.g. the Linux Standards Base. It is incredibly dangerous IMO to do this.

Also still no mention of this break in the release notes or blog post.

@bdaehlie
Copy link
Member

@bdaehlie bdaehlie commented Jul 16, 2014

Agreed it's a problem, we'll try to do something about it in the next release. Thanks for raising the issue.

@dwbuiten
Copy link
Member Author

@dwbuiten dwbuiten commented Jul 16, 2014

If it is targetted for the next release, I suposed this can be closed and folded into #21, as a blocker for the next version.

@dwbuiten
Copy link
Member Author

@dwbuiten dwbuiten commented Jul 31, 2014

Closing this bug, as it has been decided that it will be addressed in 3.0. Note should probably still exist, perhaps.

@dwbuiten dwbuiten closed this Jul 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants