Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider providing binary releases #91

Open
bdaehlie opened this issue Aug 6, 2014 · 38 comments
Open

consider providing binary releases #91

bdaehlie opened this issue Aug 6, 2014 · 38 comments
Assignees

Comments

@bdaehlie
Copy link
Member

@bdaehlie bdaehlie commented Aug 6, 2014

I was hoping to avoid doing this to keep project overhead low (having to make formal builds on a bunch of platforms every time we release), but based on feedback we probably need to consider making binaries available for popular platforms.

@bdaehlie bdaehlie added this to the v3.0 milestone Aug 6, 2014
@bdaehlie bdaehlie self-assigned this Aug 6, 2014
@dwbuiten
Copy link
Contributor

@dwbuiten dwbuiten commented Aug 6, 2014

Would it be worth it to include package recipes for RPMs and DEBs? Or are you banking on the maintainers in distros packaging mozjpeg?

@vrubleg
Copy link

@vrubleg vrubleg commented Aug 21, 2014

Please provide binaries for Windows at least.

@dwbuiten
Copy link
Contributor

@dwbuiten dwbuiten commented Aug 21, 2014

I don't mind providing these with any of the 3 common compilers (Intel, MSVC, or MinGW), but I'm sure Mozilla can provide some official builds + import libs for 3.0

@rahulsundaram
Copy link

@rahulsundaram rahulsundaram commented Oct 17, 2014

FWIW, I have built a RPM for Fedora. Review at https://bugzilla.redhat.com/show_bug.cgi?id=1154163. Unlikely to get into the repo at this point till the ABI compatibility issues are resolved but it is a starting point for those looking for a package.

@bdaehlie
Copy link
Member Author

@bdaehlie bdaehlie commented Dec 1, 2014

We can continue to consider releasing official binaries but this doesn't need to block the 3.0 release, unblocking.

@bdaehlie bdaehlie removed this from the v3.0 milestone Dec 1, 2014
@dwbuiten
Copy link
Contributor

@dwbuiten dwbuiten commented Dec 30, 2014

@bdaehlie I can provide Visual Studio and/or Intel Compiler builds for 3.0 if it is still desired.

@Ferk
Copy link

@Ferk Ferk commented Jan 4, 2015

Are there any Windows builds available?

@CoolOppo
Copy link

@CoolOppo CoolOppo commented Jan 4, 2015

@Ferk You can use my build if you need it.

The software is provided "as is", without warranty of any kind, express or implied, including but not limited to the warranties of merchantability, fitness for a particular purpose and noninfringement. In no event shall the authors or copyright holders be liable for any claim, damages or other liability, whether in an action of contract, tort or otherwise, arising from, out of or in connection with the software or the use or other dealings in the software.

You can download it here:
https://visionless.me/u/mozjpeg.exe

@RyanBram
Copy link

@RyanBram RyanBram commented Jan 30, 2015

Is it possibe to use buildbot for automate this task?
Some emulator project use it for every update.

In case somebody still looking for pre-compiled binaries, this site provide unofficial build:
http://mozjpeg.codelove.de/binaries.html

@magnetikonline
Copy link

@magnetikonline magnetikonline commented Mar 5, 2015

For a little self promotion. Have put together a Dockerfile - which produces a Debian .deb package as output. Builds 3.0 release too.

https://github.com/magnetikonline/dockermozjpegdeb

@ErtugKaya
Copy link

@ErtugKaya ErtugKaya commented Mar 18, 2015

Please provide official binaries, especially for Windows.

@CoolOppo Avast claims that your binary has a virus.

@CoolOppo
Copy link

@CoolOppo CoolOppo commented Mar 18, 2015

@ErtugKaya What is the specific message it says? I'm the one who built that, and I didn't do anything bad to it. Either the file got tampered with, or Avast is wrong, and I'm going to stick with the latter.

@ErtugKaya
Copy link

@ErtugKaya ErtugKaya commented Mar 19, 2015

@CoolOppo Avast claimed it is infected with a virus and blocked my download. I am sorry, I cannot recall the virus name. I look for a history for web shield, it seems Avast don't log web shield alarms. It's blocking that link now. So it won't warn me again.

I believe that is a false positive too.

Update:
Just this second, I stopped Avast Web Shield to be able to download the file, and do a scan on file. It says it is clean. Definitely false alarm.

@tomByrer
Copy link

@tomByrer tomByrer commented Jan 9, 2016

Windows binaries would be great.
@dwbuiten I'd prefer Intel builds; they tend to run the fastest.

@bdaehlie bdaehlie changed the title consider providing binary releases for v3.0 consider providing binary releases May 25, 2016
@TPS
Copy link

@TPS TPS commented Dec 8, 2016

It's been > 2200 commits since last binary release, which seems awfully strange, since all previous releases were done ~every 500 commits or so. Could we get a new binary release, &, even better, a bit of a firm commitment on more regular releases (even if just ßs!), please? 🙇

@kornelski
Copy link
Member

@kornelski kornelski commented Dec 8, 2016

It would be good to make another release, but Josh Aas is now busy with Let's Encrypt, and making another release is up to volunteers.

The new commits are almost exclusively from updating libjpeg-turbo, and there aren't any major updates to mozjpeg itself. However, we need to ensure that there weren't any regressions in terms of bugs as well as filesize/quality ratio.

Either way, for now you'll have to look for binaries provided by others (Linux distributions, and projects using MozJPEG internally).

@TPS
Copy link

@TPS TPS commented Dec 9, 2016

I couldn't find anyone with current daily/ß Windows binaries (especially 64-bit).… Any suggestions/leads?

@vatterspun
Copy link

@vatterspun vatterspun commented Feb 10, 2017

Just a quick note that this came up on another case here on Github: ShareX/ShareX#2270 (comment)

@JosePineiro
Copy link
Contributor

@JosePineiro JosePineiro commented May 3, 2017

You have windows binaries in https://encode.ru/threads/1892-mozjpeg

@TPS
Copy link

@TPS TPS commented May 3, 2017

@JosePineiro Official binaries are important, as, especially @ the time this was posted, even unofficial 1s are few & far between.

@kornelski
Copy link
Member

@kornelski kornelski commented May 3, 2017

There are no official binaries.

The main reason is that I don't know Windows enough to properly build libraries for Windows. I've tried providing binaries for pngquant before, and it's been an awful experience.

(There's no need to build for other platforms, since Linux package managers and Homebrew are a better way to install libraries.)

The second reason is that nobody should even need a MozJPEG binary. The intended way to use MozJPEG is via 3rd party programs. We'd like tools like ImageMagick, GIMP, Sketch, etc. to seamlessly compile/link MozJPEG into their binaries, so that end users never download anything from us. MozJPEG is specifically designed to be easily built-in into "Save As" command of almost any program that writes JPEGs.

I know this hasn't happened, so a lot of people are resorting to the cjpeg tool (sometimes renamed to mozjpeg by 3rd parties) and consider that to be the way to use MozJPEG. But that tool is not MozJPEG. It's more like a demo program using the library. It's rather basic, cumbersome and integration via external files is much less efficient than the native C API.

@CoolOppo
Copy link

@CoolOppo CoolOppo commented May 4, 2017

@pornel want me to make a quick video of how to compile MozJPEG on Windows? I know you could figure it out, but if it'd help I'll do it since I compile it all the time anyways.

Edit: I also agree with @TPS. It's important to provide official binaries, at least for Windows.

@kornelski
Copy link
Member

@kornelski kornelski commented May 4, 2017

What would be useful is if you set up a Continuous Integration servers that make Windows binaries for the master branch and all tags (exe as well as libjpeg.dll/turbojpeg.dll for popular versions of VS runtimes and MinGW, 32 and 64-bit), especially if you could package that setup as some form of image/script that can be used to rebuild it in another place later.

@CoolOppo
Copy link

@CoolOppo CoolOppo commented May 4, 2017

@pornel I'll see what I can do with AppVeyor. I don't think it supports MinGW, but it can spit out static binaries that won't depend on msvc***.dll.

@vrubleg
Copy link

@vrubleg vrubleg commented May 4, 2017

CoolOppo, BTW, it is possible to use msvcrt.dll (preinstalled since Windows 98) from the Visual Studio 2013 + WDK (it provides *.lib files for such purpose). It could be useful.

@CoolOppo
Copy link

@CoolOppo CoolOppo commented May 4, 2017

Well...that was surprisingly easy!

I figured out how to make it clone the official repo and build it from there, here it is!
https://ci.appveyor.com/project/CoolOppo/mozjpeg-svdl6/build/artifacts
Build status

@TPS
Copy link

@TPS TPS commented May 4, 2017

Could someone comment on how these compare to, say, binaries from?:

(@javiergutierrezchamorro Please be aware of these new binaries to use in FileOptimizer:

https://ci.appveyor.com/project/CoolOppo/mozjpeg-svdl6/build/artifacts)

@TPS
Copy link

@TPS TPS commented May 4, 2017

@CoolOppo I forgot to say thanks! 🙇 Could you have 64-bit binaries built, too, though?

@javiergutierrezchamorro
Copy link

@javiergutierrezchamorro javiergutierrezchamorro commented May 4, 2017

Thanks @TPS
Have now updated the x86 build on FileOptimizer. Will do with the x64 one if @CoolOppo builds a Win64 one.

@kornelski
Copy link
Member

@kornelski kornelski commented May 4, 2017

Thanks. Could you also build the actual library? libjpeg.{dll,a}?

@CoolOppo
Copy link

@CoolOppo CoolOppo commented May 4, 2017

Thanks. Could you also build the actual library? libjpeg.{dll,a}?

Yeah, I'll try and get that set up right now.

Could you have 64-bit binaries built, too, though?

I'll see what I can do :)

@JosePineiro
Copy link
Contributor

@JosePineiro JosePineiro commented May 8, 2017

I make this c# wrapper: https://github.com/JosePineiro/MozJpeg-wrapper
You have the 32 and 64 bits compiled DLL (the turbojpeg.dll) of version 3.2
Is the most easy API

@TPS
Copy link

@TPS TPS commented May 9, 2017

@JosePineiro Any luck re: x64 .exe's?

@javiergutierrezchamorro
Copy link

@javiergutierrezchamorro javiergutierrezchamorro commented May 9, 2017

Thanks, but I am interested in static EXE.

@jan-dh
Copy link

@jan-dh jan-dh commented Oct 9, 2017

Would love some official binaries. Need to use this server-side for uploaded images

@garyzyg
Copy link
Contributor

@garyzyg garyzyg commented Jul 16, 2018

Hi @kornelski,

I've created one project mozjpeg-windows to build mozjpeg binaries (for Win32 & Win64), which are linked to msvcrt.dll without additional .dll. If you would like to do similar jobs officially, you may take a look at it.

Gary

@dofuuz
Copy link
Contributor

@dofuuz dofuuz commented Sep 21, 2020

I have built 4.0.1-rc windows binary with PNG input support.
https://github.com/dofuuz/mozjpeg/releases

@Frosty-J
Copy link

@Frosty-J Frosty-J commented Jun 24, 2022

In case somebody still looking for pre-compiled binaries, this site provide unofficial build

Unfortunately, that's no more as of sometime in the past year. In the meantime, here's my own build, made on Ubuntu 22.04: mozjpeg_4.0.3_amd64.deb.tar.gz

Would anyone in charge around here be interested in building binaries using GitHub Actions or something? Shouldn't be too hard to set up and would minimise the risks that come with people relying on third-party builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests