Skip to content
This repository
Browse code

Finally fix the code so we do not test failed builds

  • Loading branch information...
commit 869860b466fbe9bfaa4fe8b2da9003d5d779d3b1 1 parent 723ee16
Henrik Skupin whimboo authored

Showing 1 changed file with 12 additions and 12 deletions. Show diff stats Hide diff stats

  1. +12 12 pulse.py
24 pulse.py
@@ -226,23 +226,23 @@ def on_build(self, data, message):
226 226 if self.debug:
227 227 self.log_notification(data, props)
228 228
229   - ## If the build process was broken we don't have to test this build
230   - #if props['build_failed']:
231   - # self.logger.info("Invalid build: %(PRODUCT)s %(VERSION)s %(PLATFORM)s %(LOCALE)s %(BUILDID)s %(PREV_BUILDID)s" % {
232   - # 'PRODUCT': product,
233   - # 'VERSION': props.get('appVersion'),
234   - # 'PLATFORM': self.get_platform_identifier(platform),
235   - # 'LOCALE': locale,
236   - # 'BUILDID': props.get('buildid'),
237   - # 'PREV_BUILDID': props.get('previous_buildid')
238   - # })
239   - # return
240   -
241 229 # Check if the routing key matches the expected regex
242 230 pattern = re.compile(self.config['pulse']['routing_key_regex'], re.IGNORECASE)
243 231 if not pattern.match(routing_key):
244 232 return
245 233
  234 + # If the build process was broken we don't have to test this build
  235 + if props['build_failed']:
  236 + self.logger.info("Invalid build: %(PRODUCT)s %(VERSION)s %(PLATFORM)s %(LOCALE)s %(BUILDID)s %(PREV_BUILDID)s" % {
  237 + 'PRODUCT': product,
  238 + 'VERSION': props.get('appVersion'),
  239 + 'PLATFORM': self.get_platform_identifier(platform),
  240 + 'LOCALE': locale,
  241 + 'BUILDID': props.get('buildid'),
  242 + 'PREV_BUILDID': props.get('previous_buildid')
  243 + })
  244 + return
  245 +
246 246 # Output logging information for received notification
247 247 self.logger.info("%s - Product: %s, Branch: %s, Platform: %s, Locale: %s" %
248 248 (data['_meta']['sent'], product, branch, platform, locale))

0 comments on commit 869860b

Please sign in to comment.
Something went wrong with that request. Please try again.