Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Create jobs for mozilla-esr17 and release-mozilla-esr17 builds (#184) #185

Closed
wants to merge 2 commits into from

3 participants

Henrik Skupin Dave Hunt Anthony Hughes
Henrik Skupin
Owner

No description provided.

Dave Hunt davehunt commented on the diff
jenkins-master/jobs/mozilla-esr17_addons/config.xml
@@ -0,0 +1,194 @@
+<?xml version='1.0' encoding='UTF-8'?>
+<project>
+ <actions/>
+ <description>Execute add-ons tests for ESR17 builds.</description>
+ <logRotator>
+ <daysToKeep>-1</daysToKeep>
+ <numToKeep>100</numToKeep>
+ <artifactDaysToKeep>-1</artifactDaysToKeep>
+ <artifactNumToKeep>-1</artifactNumToKeep>
+ </logRotator>
+ <keepDependencies>false</keepDependencies>
+ <properties>
+ <hudson.queueSorter.PrioritySorterJobProperty>
+ <priority>420</priority>
Dave Hunt Owner

Should ESR17 have a higher priority then ESR10?

Henrik Skupin Owner
whimboo added a note

I would leave this question to @ashughes1. But personally I don't think we should start messing around with the priorities here. ESR10 will go away soon so we would have to revert the priority of ESR17 again. Doesn't look worth the time given how fast we run the tests.

Henrik Skupin Owner
whimboo added a note

So for release candidate builds we have different priorities

release-mozilla-esr(CUR) = 700
release-mozilla-esr(LAST) = 600

But I'm not inclined to do the same for nightly builds. I think esr10pre and esr17pre can have the same priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Dave Hunt
Owner

Other than the question about priority, this looks good to me.

Dave Hunt davehunt commented on the diff
...s-master/jobs/release-mozilla-esr17_addons/config.xml
@@ -0,0 +1,189 @@
+<?xml version='1.0' encoding='UTF-8'?>
+<project>
+ <actions/>
+ <description>Execute add-ons tests for ESR17 candidate builds.</description>
+ <logRotator>
+ <daysToKeep>-1</daysToKeep>
+ <numToKeep>100</numToKeep>
+ <artifactDaysToKeep>-1</artifactDaysToKeep>
+ <artifactNumToKeep>-1</artifactNumToKeep>
+ </logRotator>
+ <keepDependencies>false</keepDependencies>
+ <properties>
+ <hudson.queueSorter.PrioritySorterJobProperty>
+ <priority>720</priority>
Dave Hunt Owner

According to the README we should drop priority for ESR10 or release-mozilla-esr(LAST) to 600+

Henrik Skupin Owner
whimboo added a note

Hm, interesting. So yes, lets do it. Thanks for the catch!

Henrik Skupin Owner
whimboo added a note

Fixed with the follow-up commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Dave Hunt
Owner

Looks good to me. If @ashughes1 is happy with the priorities then let's get this merged.

Anthony Hughes

You can't remove esr10 yet. We will be releasing esr10 alongside esr17 for two cycles.

Basically, this is how it will go:
esr10.0.11 + esr17.0
esr10.0.12 + esr17.0.1
esr10.0.13 + esr17.0.2
esr17.0.3

Owner

This is staging and not production! So this doesn't matter.

Collaborator

Okay, then consider it a reminder not to remove it from production. I don't see any other problems with the pull request.

Owner
Anthony Hughes
Collaborator

RE: Priority
esr10 takes higher priority than esr17.

Henrik Skupin
Owner

@ashughes1, the question for priority which is left is for the nightly builds of ESR. I still think we should prioritize both at the same level. When checking the README I don't see a differentiation between both, but only for release candidate builds.

Anthony Hughes
Collaborator

If they need different priorities, I would give nightly ESR17 a bit higher since it will live the longest. If they can be the same, I have no issues.

Henrik Skupin
Owner

As already mentioned at #185 (comment) it would cause us a lot of updates which I do not think are worth our time. I would go with the same priority for now and if it really turns out we need a different one, we would have to do it. Does that sound fine?

Anthony Hughes
Collaborator

yes

Henrik Skupin
Owner

Thanks. So I'm going to land this now and get it tested on staging before I merge it to production tomorrow.

Dave Hunt
Owner

We should include new views for ESR17 too.

Henrik Skupin
Owner

Oh, good catch Dave! I know I missed something. I will open a new pull for this additional patch.

Henrik Skupin whimboo closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.