Create jobs for mozilla-esr17 and release-mozilla-esr17 builds (#184) #185

Closed
wants to merge 2 commits into
from

3 participants

@whimboo

No description provided.

@davehunt davehunt commented on the diff Nov 19, 2012
jenkins-master/jobs/mozilla-esr17_addons/config.xml
@@ -0,0 +1,194 @@
+<?xml version='1.0' encoding='UTF-8'?>
+<project>
+ <actions/>
+ <description>Execute add-ons tests for ESR17 builds.</description>
+ <logRotator>
+ <daysToKeep>-1</daysToKeep>
+ <numToKeep>100</numToKeep>
+ <artifactDaysToKeep>-1</artifactDaysToKeep>
+ <artifactNumToKeep>-1</artifactNumToKeep>
+ </logRotator>
+ <keepDependencies>false</keepDependencies>
+ <properties>
+ <hudson.queueSorter.PrioritySorterJobProperty>
+ <priority>420</priority>
@davehunt
Mozilla member
davehunt added a line comment Nov 19, 2012

Should ESR17 have a higher priority then ESR10?

@whimboo
whimboo added a line comment Nov 19, 2012

I would leave this question to @ashughes1. But personally I don't think we should start messing around with the priorities here. ESR10 will go away soon so we would have to revert the priority of ESR17 again. Doesn't look worth the time given how fast we run the tests.

@whimboo
whimboo added a line comment Nov 19, 2012

So for release candidate builds we have different priorities

release-mozilla-esr(CUR) = 700
release-mozilla-esr(LAST) = 600

But I'm not inclined to do the same for nightly builds. I think esr10pre and esr17pre can have the same priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@davehunt
Mozilla member

Other than the question about priority, this looks good to me.

@davehunt davehunt commented on the diff Nov 19, 2012
...s-master/jobs/release-mozilla-esr17_addons/config.xml
@@ -0,0 +1,189 @@
+<?xml version='1.0' encoding='UTF-8'?>
+<project>
+ <actions/>
+ <description>Execute add-ons tests for ESR17 candidate builds.</description>
+ <logRotator>
+ <daysToKeep>-1</daysToKeep>
+ <numToKeep>100</numToKeep>
+ <artifactDaysToKeep>-1</artifactDaysToKeep>
+ <artifactNumToKeep>-1</artifactNumToKeep>
+ </logRotator>
+ <keepDependencies>false</keepDependencies>
+ <properties>
+ <hudson.queueSorter.PrioritySorterJobProperty>
+ <priority>720</priority>
@davehunt
Mozilla member
davehunt added a line comment Nov 19, 2012

According to the README we should drop priority for ESR10 or release-mozilla-esr(LAST) to 600+

@whimboo
whimboo added a line comment Nov 19, 2012

Hm, interesting. So yes, lets do it. Thanks for the catch!

@whimboo
whimboo added a line comment Nov 19, 2012

Fixed with the follow-up commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@davehunt
Mozilla member

Looks good to me. If @ashughes1 is happy with the priorities then let's get this merged.

@ashughes1

You can't remove esr10 yet. We will be releasing esr10 alongside esr17 for two cycles.

Basically, this is how it will go:
esr10.0.11 + esr17.0
esr10.0.12 + esr17.0.1
esr10.0.13 + esr17.0.2
esr17.0.3

This is staging and not production! So this doesn't matter.

Okay, then consider it a reminder not to remove it from production. I don't see any other problems with the pull request.

@ashughes1

RE: Priority
esr10 takes higher priority than esr17.

@whimboo

@ashughes1, the question for priority which is left is for the nightly builds of ESR. I still think we should prioritize both at the same level. When checking the README I don't see a differentiation between both, but only for release candidate builds.

@ashughes1

If they need different priorities, I would give nightly ESR17 a bit higher since it will live the longest. If they can be the same, I have no issues.

@whimboo

As already mentioned at #185 (comment) it would cause us a lot of updates which I do not think are worth our time. I would go with the same priority for now and if it really turns out we need a different one, we would have to do it. Does that sound fine?

@whimboo

Thanks. So I'm going to land this now and get it tested on staging before I merge it to production tomorrow.

@davehunt
Mozilla member

We should include new views for ESR17 too.

@whimboo

Oh, good catch Dave! I know I missed something. I will open a new pull for this additional patch.

@whimboo whimboo closed this Nov 20, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment