Dot releases (.1) are not filtered correctly #86

Closed
cosmin-malutan opened this Issue Jan 20, 2014 · 10 comments

4 participants

@cosmin-malutan

esr 24.1 or esr 24.2 builds are not filtered under http://mozmill-release.blargon7.com/#/functional/reports
I've noticed this while I was doing the testrun reports and it lead me to think that the jobs were not ran against esr24 builds.

@whimboo

I think a simple update to the filter is necessary here. The last link from @andreieftimie above with 24 as value looks fine to me. Then we are independent from the versioning schema.

@whimboo

@tojonmz, would you be interested in this PR?

@tojon

Sure, I will have a go.

@tojon

After looking at the code, and also consulting with Henrik yesterday on IRC, we both think that the change may be as simple as modifying the config file. I will make change and open a PR to perhaps try in sandbox.

Related - I will continue work setting up a local couchdb to support ongoing dashboard dev work, but ran into a few snags yesterday getting the dashboard displaying.

@tojon tojon added a commit to tojon/mozmill-dashboard that referenced this issue Jan 30, 2014
@tojon tojon Always filter and report all esr runs (#86) 6c1d0d3
@tojon

PR #89

@tojon

I closed the pull request above since someone else in SV or Moz is intending to take this issue due to the fix's timing requirements; so they will create their own PR.

@whimboo whimboo added the javascript label May 15, 2014
@whimboo whimboo changed the title from Esr24 reports are not filtered correctly to Dot releases (.1) are not filtered correctly Nov 26, 2014
@whimboo

So the problem here is that we index documents by branch in form of major.minor. That means that we get different branches for e.g. 31.0, 31.1 etc. The filters we have in the dashboard are major.0 only, so they won't match anything else than that and major.1 will not be incorporated.

The only helpful solution I see here is that we filter only by major version, which would allow us to apply all of our filters:

33.0 => 33
33.1 => 33
33.1.1 => 33

Then we can have a filter with the value 33 and all reports for the 33 releases will be shown. @andreieftimie what do you think?

Keep in mind that a change like that will affect all the indexed documents, so a complete re-index would be necessary! This might take a couple of hours, unless we could think about to drop all the existent reports we have. I tried in the past to delete older entries via a script but that wasn't working that well.

@whimboo whimboo self-assigned this Nov 27, 2014
@whimboo

PR #132 has been fixed. I will deploy the code to all dashboard instances. Keep in mind that the dashboard will not be available for a couple hours due to re-indexing!

@whimboo

All dashboard have been updated with the new index code. A quick check shows that daily will be back in about 1h, and release in 1.5h.

@whimboo whimboo closed this Nov 27, 2014
@whimboo whimboo was unassigned by moz-hwine Aug 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment