Properly align the labels in the Filter box #90

Closed
andreieftimie opened this Issue Feb 14, 2014 · 9 comments

Comments

Projects
None yet
3 participants
@andreieftimie
Contributor

andreieftimie commented Feb 14, 2014

We should properly align the labels and filter options in the Filter box.

@whimboo whimboo added mentored and removed bug labels Feb 17, 2014

@whimboo

This comment has been minimized.

Show comment Hide comment
@whimboo

whimboo Feb 17, 2014

Contributor

More like a nice enhancement. Putting up as mentored issue.

Contributor

whimboo commented Feb 17, 2014

More like a nice enhancement. Putting up as mentored issue.

@tojon

This comment has been minimized.

Show comment Hide comment
@tojon

tojon May 9, 2014

Contributor

I've been looking at this locally with divs and css. Close but the Date block still needs tuning.

Contributor

tojon commented May 9, 2014

I've been looking at this locally with divs and css. Close but the Date block still needs tuning.

@tojon

This comment has been minimized.

Show comment Hide comment
@tojon

tojon May 9, 2014

Contributor

Ok, Date block is tuned. It's not in the mustache templates yet, but here's a before and after:

filterbefore

filterafter

The after is slightly shorter now than it was before also.

Contributor

tojon commented May 9, 2014

Ok, Date block is tuned. It's not in the mustache templates yet, but here's a before and after:

filterbefore

filterafter

The after is slightly shorter now than it was before also.

@whimboo whimboo added the css label May 15, 2014

@whimboo

This comment has been minimized.

Show comment Hide comment
@whimboo

whimboo May 15, 2014

Contributor

That looks great. So yeah, lets go with that. Thanks @tojonmz!

Contributor

whimboo commented May 15, 2014

That looks great. So yeah, lets go with that. Thanks @tojonmz!

@tojon

This comment has been minimized.

Show comment Hide comment
@tojon

tojon May 15, 2014

Contributor

I've integrated the changes into my local dashboard using functional_reports. @andreieftimie if you can have a quick look below, I will push some code to my remote and you can check out my changes.

Firefox and Chrome on Windows, render the date boxes a bit differently. I had to split the difference, Firefox's date box is now essentially lined up 1px left, Chrome is doing its own thing, several px right. Perhaps it will look different yet again on Linux or OSX. You'd have to peer closely to see the differences but if you look at the leading edge of the 1st box you see they aren't perfectly lined up.

Here's Firefox, and Chrome:

filteralignintegfirefox

filteralignintegchrome

Contributor

tojon commented May 15, 2014

I've integrated the changes into my local dashboard using functional_reports. @andreieftimie if you can have a quick look below, I will push some code to my remote and you can check out my changes.

Firefox and Chrome on Windows, render the date boxes a bit differently. I had to split the difference, Firefox's date box is now essentially lined up 1px left, Chrome is doing its own thing, several px right. Perhaps it will look different yet again on Linux or OSX. You'd have to peer closely to see the differences but if you look at the leading edge of the 1st box you see they aren't perfectly lined up.

Here's Firefox, and Chrome:

filteralignintegfirefox

filteralignintegchrome

@andreieftimie

This comment has been minimized.

Show comment Hide comment
@andreieftimie

andreieftimie May 16, 2014

Contributor

Looks great.
Don't sweat cross-browser pixel perfection.

Please issue a PR or push your changes to http://mozmill-sandbox.blargon7.com
Both would probably be better :)

Contributor

andreieftimie commented May 16, 2014

Looks great.
Don't sweat cross-browser pixel perfection.

Please issue a PR or push your changes to http://mozmill-sandbox.blargon7.com
Both would probably be better :)

@tojon

This comment has been minimized.

Show comment Hide comment
@tojon

tojon May 16, 2014

Contributor

Ok, I'm going to push the one template only to my remote first, so you can have a look. I'm sure there may be some tuning of css id or class names needed. Then after I will propagate the same changes to all the templates, and open a PR.

Contributor

tojon commented May 16, 2014

Ok, I'm going to push the one template only to my remote first, so you can have a look. I'm sure there may be some tuning of css id or class names needed. Then after I will propagate the same changes to all the templates, and open a PR.

tojon added a commit to tojon/mozmill-dashboard that referenced this issue May 16, 2014

andreieftimie added a commit to andreieftimie/mozmill-dashboard that referenced this issue May 22, 2014

andreieftimie added a commit to andreieftimie/mozmill-dashboard that referenced this issue May 26, 2014

andreieftimie added a commit to andreieftimie/mozmill-dashboard that referenced this issue May 26, 2014

@andreieftimie

This comment has been minimized.

Show comment Hide comment
@andreieftimie

andreieftimie May 26, 2014

Contributor

Merged as f89bf0e
And pushed to all instances.

Contributor

andreieftimie commented May 26, 2014

Merged as f89bf0e
And pushed to all instances.

@whimboo

This comment has been minimized.

Show comment Hide comment
@whimboo

whimboo May 26, 2014

Contributor

Wonderful. Thanks!

Contributor

whimboo commented May 26, 2014

Wonderful. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment