From 4b3ceb229e9a85adba7b8839b4088740357a3d5d Mon Sep 17 00:00:00 2001 From: William Lachance Date: Tue, 4 Feb 2014 15:53:25 -0500 Subject: [PATCH] Include previous day's builds in potential inbound range Starting from the current nightly revision may not be good enough, as there may have been commits to inbound between the time yesterday's nightly was built and the last time that m-c commit was merged into inbound. (this solution is not perfect either but it should work for 99% of cases) https://bugzilla.mozilla.org/show_bug.cgi?id=962742 --- mozregression/regression.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/mozregression/regression.py b/mozregression/regression.py index 31fc137db..fc2d9970a 100755 --- a/mozregression/regression.py +++ b/mozregression/regression.py @@ -147,10 +147,15 @@ def bisect_nightlies(self, goodDate, badDate, skips=0): if midDate == badDate or midDate == goodDate: print "Got as far as we can go bisecting nightlies..." - self._ensureMetadata(goodDate, badDate) if self.appname == 'firefox' or self.appname == 'fennec': + self._ensureMetadata(goodDate, badDate) self.printRange(goodDate, badDate) - print "... attempting to bisect inbound builds" + print "... attempting to bisect inbound builds (starting " \ + "from previous day, to make sure no inbound revision is " \ + "missed)" + prevDate = goodDate - datetime.timedelta(days=1) + self.nightlyRunner.install(prevDate) + self.lastGoodRevision = self.nightlyRunner.getAppInfo()[1] self.bisect_inbound() return else: