Bug 1211147 - [gui] allow to use debug builds in the gui #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeLing
force-pushed
the
bugfix-1211147
branch
from
5432554 to
cd6981b
Compare
gui/mozregui/wizard.py
Outdated
There was a problem hiding this comment.
@parkouss I'm curious about why it keeps telling me no attribute 'BUILD_TYPES'
Traceback (most recent call last):
File "/Users/mikeling/mozregression/gui/mozregui/wizard.py", line 202, in initializePage
[FC_REGISTRY.get(str(application_name)).BUILD_TYPES])
AttributeError: type object 'FirefoxConfig' has no attribute 'BUILD_TYPES'
MikeLing
force-pushed
the
bugfix-1211147
branch
from
cd6981b to
4a0053a
Compare
gui/mozregui/ui/inbound.ui
Outdated
There was a problem hiding this comment.
Please remove "notice only opt is available most of time". (we handle every case for inbound, the warning was for users using command lines and nightlies).
MikeLing
force-pushed
the
bugfix-1211147
branch
from
4a0053a to
e4cc414
Compare
|
Done! Thank you for your help @parkouss |
|
Yup, thank you! Merged manually in 40b34f3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.