Fix bug 1195296 #343
Fix bug 1195296 #343
Conversation
mozregression/launchers.py
Outdated
There was a problem hiding this comment.
profile can be None - so it should be something like "if profile and not os.path.exists(profile)".
There was a problem hiding this comment.
Made the suggested change.
|
Thanks @ShivamNegi, we're almost there! Well first thing I would like to see the dir creation in create_profile, just after https://github.com/mozilla/mozregression/pull/343/files#diff-9be3d66461b771098aa1bcc305505480R129 for example - this way the fennec launcher will also benefits from the fix (sorry I missed that first time). And this make sense to have the create_profile do this task. Second thing is a small nit - we run flake8 on travis-ci (see check panel above) and you have a small trailing whitespace: https://travis-ci.org/mozilla/mozregression/builds/88289171#L281 Can you fix that ? Thanks for working on this bug. :) |
2 participants
To create a profile in case of a non existing profile specified by the user, these two lines have been added in /mozregression/launchers.py. Which creates the directory corresponding to the profile path specified.