Issue #87. Moztrap #5932 #102

Merged
merged 3 commits into from Mar 1, 2013

Conversation

Projects
None yet
4 participants
Contributor

sashakruglov commented Feb 1, 2013

improved test performance.

before: 2 passed in 570.79 seconds
after: 2 passed in 430.28 seconds

that forced me to use some hack. but it's a clean and fair hack.

I've replaced
Select(select_el).first_selected_option.text
by
select_el.find_element(By.CSS_SELECTOR, 'option:checked').text.

I hope that it's OK to use this.

Contributor

AlinT commented Feb 12, 2013

I don't see any problems in dropping the use of the Select class, when this improves the execution time by ~ 2 minnutes.
Also please resolve the merge conflicts.

Contributor

sashakruglov commented Feb 12, 2013

Resolved merge conflict

@@ -104,6 +104,8 @@ def find_element(self, *locator):
def find_elements(self, *locator):
return self._selenium_root.find_elements(*locator)
+ def go_back(self):
+ self.selenium.back()
@AndreiH

AndreiH Feb 15, 2013

Contributor

a pep8 issue here, expected 2 blank lines

Contributor

AndreiH commented Feb 15, 2013

Looks good, ran the tests and looked over the code.

Contributor

teodosia commented Mar 1, 2013

Lgtm too and the tests pass. Merging this.

teodosia added a commit that referenced this pull request Mar 1, 2013

@teodosia teodosia merged commit 9e14ad4 into mozilla:master Mar 1, 2013

@sashakruglov sashakruglov deleted the sashakruglov:moztrap_5932 branch Mar 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment