Repair remove filter method #67

Merged
merged 1 commit into from Oct 1, 2012

Conversation

Projects
None yet
3 participants
Contributor

zacc commented Sep 28, 2012

This was not clicking/waiting properly.

Changed the locator and also made the wait more explicit.

Contributor

teodosia commented Oct 1, 2012

Lgtm and all tests pass.

@AlinT AlinT commented on the diff Oct 1, 2012

pages/manage_products_page.py
- self.selenium.find_element(*_filter_locator).click()
- self.wait_for_ajax()
+ self.selenium.find_element(*_filter_remove_locator).click()
+ WebDriverWait(self.selenium, self.timeout).until(lambda s: not self.is_element_visible(*_filter_remove_locator))
@AlinT

AlinT Oct 1, 2012

Contributor

self is missing from the inside of the is_element_visible method

@zacc

zacc Oct 1, 2012

Contributor

no it's using the local variable created in the method.
This is not our usual style of course, it's a legacy style from RC moztrap.

@AlinT AlinT added a commit that referenced this pull request Oct 1, 2012

@AlinT AlinT Merge pull request #67 from zacc/update_filter_remove_wait
Repair remove filter method
30f7491

@AlinT AlinT merged commit 30f7491 into mozilla:master Oct 1, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment