Remove xfails due to resolved bugs #70

Merged
merged 1 commit into from Oct 3, 2012

Conversation

Projects
None yet
5 participants
Contributor

AlinT commented Oct 1, 2012

Although bug 795283 hasn't been marked resolved fixed. it has been fixed and is currently waiting for a dependency bug.

Remove xfails due to resolved bugs
Although bug 795283 hasn't been marked resolved fixed. it has been fixed and is currently waiting for a dependency bug.
Contributor

klrmn commented Oct 1, 2012

i've just run the master branch (not this pull) against moztrap-dev, and the test_manage_products_page cases are still xfailing, not xpassing. i think you may have removed too many xfail markers.

tests/test_manage_products_page.py .xx
tests/test_run_tests_page.py XXX

Contributor

bebef1987 commented Oct 2, 2012

@AlinT Bug 795283 is still open why did we remove the xfails?

Collaborator

m8ttyB commented Oct 2, 2012

Good catch @klrmn & @bebef1987 -- let's get this remedied and merged. The beast better known as Jenkins is hungry for coverage on Mozillians.

Keep the pull requests coming :-)

Contributor

AlinT commented Oct 3, 2012

@klrmn @bebef1987 has anyone of you read the content of the bug https://bugzilla.mozilla.org/show_bug.cgi?id=795283 ???
Sorry to disappoint you @m8ttyB but it was not a nice catch, it was not even a catch.
As I've said in the description of this pull request "bug 795283 hasn't been marked resolved fixed. it has been fixed and is currently waiting for a dependency bug." which does not affect our automated tests.
So please next time read the content of the bug before leaving an undocumented comment.
This is a run from right now:
tests/test_homepage.py ....
tests/test_manage_cases_page.py .
tests/test_manage_products_page.py ...
tests/test_manage_profiles_page.py .
tests/test_manage_runs_page.py X
tests/test_manage_suites_page.py .
tests/test_manage_versions_page.py ...
tests/test_run_tests_page.py ...
Also if you see the latest moztrap.dev build ( http://qa-selenium.mv.mozilla.com:8080/job/moztrap.dev/748/ )there are 6 xpasses which I've removed in this pulls request.

Contributor

zacc commented Oct 3, 2012

I've run it too and matched @AlinT 's results . It sounds like from the bug that this issue could return if too much data is left in the database but this will get us the coverage back for now.

zacc pushed a commit that referenced this pull request Oct 3, 2012

Merge pull request #70 from AlinT/rem_xfails
Remove xfails due to resolved bugs

@zacc zacc merged commit 2c7da5a into mozilla:master Oct 3, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment