Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Remove xfails due to resolved bugs #70

Merged
merged 1 commit into from

5 participants

@AlinT

Although bug 795283 hasn't been marked resolved fixed. it has been fixed and is currently waiting for a dependency bug.

@AlinT AlinT Remove xfails due to resolved bugs
Although bug 795283 hasn't been marked resolved fixed. it has been fixed and is currently waiting for a dependency bug.
8d7054b
@klrmn
Collaborator

i've just run the master branch (not this pull) against moztrap-dev, and the test_manage_products_page cases are still xfailing, not xpassing. i think you may have removed too many xfail markers.

tests/test_manage_products_page.py .xx
tests/test_run_tests_page.py XXX

@bebef1987
Collaborator

@AlinT Bug 795283 is still open why did we remove the xfails?

@m8ttyB
Owner

Good catch @klrmn & @bebef1987 -- let's get this remedied and merged. The beast better known as Jenkins is hungry for coverage on Mozillians.

Keep the pull requests coming :-)

@AlinT

@klrmn @bebef1987 has anyone of you read the content of the bug https://bugzilla.mozilla.org/show_bug.cgi?id=795283 ???
Sorry to disappoint you @m8ttyB but it was not a nice catch, it was not even a catch.
As I've said in the description of this pull request "bug 795283 hasn't been marked resolved fixed. it has been fixed and is currently waiting for a dependency bug." which does not affect our automated tests.
So please next time read the content of the bug before leaving an undocumented comment.
This is a run from right now:
tests/test_homepage.py ....
tests/test_manage_cases_page.py .
tests/test_manage_products_page.py ...
tests/test_manage_profiles_page.py .
tests/test_manage_runs_page.py X
tests/test_manage_suites_page.py .
tests/test_manage_versions_page.py ...
tests/test_run_tests_page.py ...
Also if you see the latest moztrap.dev build ( http://qa-selenium.mv.mozilla.com:8080/job/moztrap.dev/748/ )there are 6 xpasses which I've removed in this pulls request.

@zacc

I've run it too and matched @AlinT 's results . It sounds like from the bug that this issue could return if too much data is left in the database but this will get us the coverage back for now.

@zacc zacc merged commit 2c7da5a into mozilla:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 1, 2012
  1. @AlinT

    Remove xfails due to resolved bugs

    AlinT authored
    Although bug 795283 hasn't been marked resolved fixed. it has been fixed and is currently waiting for a dependency bug.
This page is out of date. Refresh to see the latest.
View
2  tests/test_manage_products_page.py
@@ -26,7 +26,6 @@ def test_that_user_can_create_and_delete_product(self, mozwebqa_logged_in):
Assert.false(manage_products_pg.is_element_present(*product['locator']))
- @pytest.mark.xfail(reason = "795244 - [dev]Searching by name for a product just created does not return any results ")
def test_that_user_can_filter_product_by_name(self, mozwebqa_logged_in):
manage_products_pg = MozTrapManageProductsPage(mozwebqa_logged_in)
@@ -43,7 +42,6 @@ def test_that_user_can_filter_product_by_name(self, mozwebqa_logged_in):
manage_products_pg.delete_product(name=product['name'])
- @pytest.mark.xfail(reason = "795244 - [dev]Searching by name for a product just created does not return any results ")
def test_that_user_can_filter_product_by_name_without_mouse(self, mozwebqa_logged_in):
manage_products_pg = MozTrapManageProductsPage(mozwebqa_logged_in)
View
4 tests/test_run_tests_page.py
@@ -4,7 +4,6 @@
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
-import pytest
from unittestzero import Assert
from pages.base_test import BaseTest
@@ -13,7 +12,6 @@
class TestRunTestsPage(BaseTest):
- @pytest.mark.xfail(reason="Bug 795283 - [dev] https://moztrap-dev.allizom.org/manage/suite/add/ returns 503[Service Unavailable]")
def test_that_user_can_pass_test(self, mozwebqa_logged_in):
run_tests_pg = MozTrapRunTestsPage(mozwebqa_logged_in)
@@ -28,7 +26,6 @@ def test_that_user_can_pass_test(self, mozwebqa_logged_in):
self.delete_product(mozwebqa_logged_in, product=case['product'])
self.delete_profile(mozwebqa_logged_in, profile=case['profile'])
- @pytest.mark.xfail(reason="Bug 795283 - [dev] https://moztrap-dev.allizom.org/manage/suite/add/ returns 503[Service Unavailable]")
def test_that_user_can_fail_test(self, mozwebqa_logged_in):
run_tests_pg = MozTrapRunTestsPage(mozwebqa_logged_in)
@@ -43,7 +40,6 @@ def test_that_user_can_fail_test(self, mozwebqa_logged_in):
self.delete_product(mozwebqa_logged_in, product=case['product'])
self.delete_profile(mozwebqa_logged_in, profile=case['profile'])
- @pytest.mark.xfail(reason="Bug 795283 - [dev] https://moztrap-dev.allizom.org/manage/suite/add/ returns 503[Service Unavailable]")
def test_that_user_can_mark_test_invalid(self, mozwebqa_logged_in):
run_tests_pg = MozTrapRunTestsPage(mozwebqa_logged_in)
Something went wrong with that request. Please try again.