Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

test_that_user_can_create_suite_and_add_some_cases_to_it #79

Merged
merged 3 commits into from Oct 30, 2012

Conversation

Projects
None yet
5 participants
Contributor

bebef1987 commented Oct 23, 2012

fix #78

Contributor

AlinT commented Oct 24, 2012

Contributor

bebef1987 commented Oct 24, 2012

@AlinT this is passing on my end... are you running your tests on mac?

@AlinT AlinT commented on an outdated diff Oct 24, 2012

tests/test_manage_suites_page.py
@@ -10,6 +10,7 @@
from pages.manage_suites_page import MozTrapManageSuitesPage
+
@AlinT

AlinT Oct 24, 2012

Contributor

Too many blank lines(3)

Contributor

AlinT commented Oct 24, 2012

Yeah, you were right.Totally forgot to run the test on mac.
Ran it again and it passed flawlessly.
Lgtm, except for the pep8 comment!

Contributor

bebef1987 commented Oct 24, 2012

updated

Contributor

zacc commented Oct 24, 2012

What is different that makes it pass on mac and fail on other?

Contributor

bebef1987 commented Oct 24, 2012

it's the webdriver

sometimes the locator has to me more specific on windows...

@bebef1987 bebef1987 closed this Oct 24, 2012

@bebef1987 bebef1987 reopened this Oct 24, 2012

Contributor

bebef1987 commented Oct 24, 2012

Sorry for that wrong button

Contributor

zacc commented Oct 24, 2012

OK. It'd be nice to get this working on both one day as I can't see any critical reason why it shouldn't run on both (ie ActionChains for example).

Just running the test on the one that gives you the result and calling it a success is a bad practice.

Contributor

bebef1987 commented Oct 24, 2012

I'm ok with that...
Also I'm running the test on the env used on jenkins

Contributor

teodosia commented Oct 29, 2012

I ran the test and it fails for me. Here is the stacktrace.http://pastebin.mozilla.org/1888425

Contributor

klrmn commented Oct 29, 2012

both tests in the file passed for me on, XP+FF15, Mac+FF13, and Mac+FF15. @teodosia, is it possible that your FF version is not playing nice with the selenium version?

Contributor

AlinT commented Oct 30, 2012

The test passed on Mac+FF14 and failed on Win7+Ff14.
it seems there is a problem with the cases locator on windows.
@bebef1987 any ideas on how we can strengthen the locators or the test?

Contributor

bebef1987 commented Oct 30, 2012

I updated the locator it should work on both OS

Contributor

AlinT commented Oct 30, 2012

Great fix!
Lgtm & merging! tests pass both on mac&win7+FF14!

AlinT added a commit that referenced this pull request Oct 30, 2012

Merge pull request #79 from bebef1987/2741
test_that_user_can_create_suite_and_add_some_cases_to_it

@AlinT AlinT merged commit a1b75ee into mozilla:master Oct 30, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment