New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow classifying of sites or urls as private,work, ... #306

Closed
crabel opened this Issue Mar 2, 2017 · 11 comments

Comments

Projects
None yet
10 participants
@crabel

crabel commented Mar 2, 2017

Some urls/sites are always "private", some are always "work". At least for me. So, it would be nice, if those urls would be opened automatically as "private" or "work" when I type them or select them from bookmarks.

Currently I have to choose the type of a tab, before I open it. Otherwise it is opened in a "standard" tab.

But I really would like to be able to simply type the url or choose it from my bookmarks and the correct (previously "mapped") tag is used automatically.

Note: This feature shouldn't extend to links I click, only to bookmarks and links I type.
Note2: If I select the type "private" manually, it should also not override my manual setting.

@groovecoder

This comment has been minimized.

Show comment
Hide comment
@groovecoder

groovecoder Mar 2, 2017

Member

We anticipate this enhancement may get a lot of up-votes. 😄

Member

groovecoder commented Mar 2, 2017

We anticipate this enhancement may get a lot of up-votes. 😄

@groovecoder groovecoder added this to the Stretch milestone Mar 2, 2017

@chris-morgan

This comment has been minimized.

Show comment
Hide comment
@chris-morgan

chris-morgan Mar 3, 2017

Note: This feature shouldn't extend to links I click, only to bookmarks and links I type.

By “links I click” I presume you mean from inside the browser. Links from outside the browser should open in the classified container as though I had typed them.

chris-morgan commented Mar 3, 2017

Note: This feature shouldn't extend to links I click, only to bookmarks and links I type.

By “links I click” I presume you mean from inside the browser. Links from outside the browser should open in the classified container as though I had typed them.

@cpeterso

This comment has been minimized.

Show comment
Hide comment
@cpeterso

cpeterso Mar 3, 2017

Once the extension has the capability to remember containers for sites, it would be interesting to include a default classification list for popular sites. So out of the box, facebook.com might automatically be assigned to the Personal container and amazon.com to the Shopping container without any user configuration.

cpeterso commented Mar 3, 2017

Once the extension has the capability to remember containers for sites, it would be interesting to include a default classification list for popular sites. So out of the box, facebook.com might automatically be assigned to the Personal container and amazon.com to the Shopping container without any user configuration.

@crabel

This comment has been minimized.

Show comment
Hide comment
@crabel

crabel Mar 3, 2017

@chris-morgan Yes, I meant: "Links I click in a tab". Links from outside should be treaded the same as bookmarks or links I enter in a new tab. I also don't think a container should change. When I open a "private" container and type a "work" url, it should stay "private". (Note: I am not a 100% attached to this behavior, but I think it is the most clear/logic/intuitive)

The main question for me is, will people understand that. I mean, you are in the shopping container and click some link "Login with Facebook" or something. And then they complain, because they are already authenticated (of course, in the other container). But that's a question that affects the whole idea of containers. I think, the idea of separation needs to be communicated very clearly, e.g. with a nice image showing that each container is "its own world".

crabel commented Mar 3, 2017

@chris-morgan Yes, I meant: "Links I click in a tab". Links from outside should be treaded the same as bookmarks or links I enter in a new tab. I also don't think a container should change. When I open a "private" container and type a "work" url, it should stay "private". (Note: I am not a 100% attached to this behavior, but I think it is the most clear/logic/intuitive)

The main question for me is, will people understand that. I mean, you are in the shopping container and click some link "Login with Facebook" or something. And then they complain, because they are already authenticated (of course, in the other container). But that's a question that affects the whole idea of containers. I think, the idea of separation needs to be communicated very clearly, e.g. with a nice image showing that each container is "its own world".

@jonathanKingston

This comment has been minimized.

Show comment
Hide comment
@jonathanKingston

jonathanKingston Mar 3, 2017

Member

If we implement this only for URL bar and bookmarks I think we could drop the default on link clicks within containers perhaps.

We could also consider cookies in other containers to provide the user with options on link press too. So if the user has clicked a link within work mail to github we could look at cookies and offer a modal to allow them to approve jumping into a work or personal container. That way we keep the security/privacy benefits of containers whilst offering the most contextual UX.

Member

jonathanKingston commented Mar 3, 2017

If we implement this only for URL bar and bookmarks I think we could drop the default on link clicks within containers perhaps.

We could also consider cookies in other containers to provide the user with options on link press too. So if the user has clicked a link within work mail to github we could look at cookies and offer a modal to allow them to approve jumping into a work or personal container. That way we keep the security/privacy benefits of containers whilst offering the most contextual UX.

@groovecoder groovecoder removed the needs: UX label Mar 3, 2017

@kyleloyka

This comment has been minimized.

Show comment
Hide comment
@kyleloyka

kyleloyka Mar 10, 2017

Could this idea be expanded so that by default, there could be a separate container for every (visited) root domain?

kyleloyka commented Mar 10, 2017

Could this idea be expanded so that by default, there could be a separate container for every (visited) root domain?

@groovecoder

This comment has been minimized.

Show comment
Hide comment
@groovecoder

groovecoder Mar 10, 2017

Member

@kyleloyka - that's essentially First Party Isolation as done by Tor. It's being uplifted to Firefox.

Member

groovecoder commented Mar 10, 2017

@kyleloyka - that's essentially First Party Isolation as done by Tor. It's being uplifted to Firefox.

@Shnoulle

This comment has been minimized.

Show comment
Hide comment
@Shnoulle

Shnoulle Mar 25, 2017

would be interesting to include a default classification list for popular sites.

No default classification : who made decisioon about popular site ? Why i can't use facebook as professionnal only, (and currently need facebook as facebook container, like twitter as twitter container)

Shnoulle commented Mar 25, 2017

would be interesting to include a default classification list for popular sites.

No default classification : who made decisioon about popular site ? Why i can't use facebook as professionnal only, (and currently need facebook as facebook container, like twitter as twitter container)

@klint

This comment has been minimized.

Show comment
Hide comment
@klint

klint Mar 27, 2017

I totally support this request. Either with simple URL-matching rules or regex-based for those who dare :)
Thanks

klint commented Mar 27, 2017

I totally support this request. Either with simple URL-matching rules or regex-based for those who dare :)
Thanks

jonathanKingston added a commit to jonathanKingston/multi-account-containers that referenced this issue Mar 27, 2017

jonathanKingston added a commit to jonathanKingston/multi-account-containers that referenced this issue Mar 28, 2017

jonathanKingston added a commit to jonathanKingston/multi-account-containers that referenced this issue Mar 29, 2017

jonathanKingston added a commit to jonathanKingston/multi-account-containers that referenced this issue Mar 30, 2017

jonathanKingston added a commit to jonathanKingston/multi-account-containers that referenced this issue Mar 30, 2017

jonathanKingston added a commit to jonathanKingston/multi-account-containers that referenced this issue Mar 30, 2017

@ChenMorpheus

This comment has been minimized.

Show comment
Hide comment
@ChenMorpheus

ChenMorpheus Mar 31, 2017

That's a great feature we're missing right now!! I'd tried to come up with some mockups which might combine different requests on Github, but I still want to know more about the feasibility before digging deeper.

Based on @crabel 's request here, I was wondering what flexibility we have for awesome bar and bookmark since I remembered that we could not effect awesome bar or Firefox library? Please noted that the attached screen is my rough ideas for quick feasibility check and also try to provide more inspirations, thanks.

awesome bar
awesome bar copy

ChenMorpheus commented Mar 31, 2017

That's a great feature we're missing right now!! I'd tried to come up with some mockups which might combine different requests on Github, but I still want to know more about the feasibility before digging deeper.

Based on @crabel 's request here, I was wondering what flexibility we have for awesome bar and bookmark since I remembered that we could not effect awesome bar or Firefox library? Please noted that the attached screen is my rough ideas for quick feasibility check and also try to provide more inspirations, thanks.

awesome bar
awesome bar copy

jonathanKingston added a commit to jonathanKingston/multi-account-containers that referenced this issue Mar 31, 2017

jonathanKingston added a commit to jonathanKingston/multi-account-containers that referenced this issue Mar 31, 2017

jonathanKingston added a commit to jonathanKingston/multi-account-containers that referenced this issue Apr 3, 2017

jonathanKingston added a commit to jonathanKingston/multi-account-containers that referenced this issue Apr 3, 2017

@groovecoder

This comment has been minimized.

Show comment
Hide comment
@groovecoder

groovecoder Apr 3, 2017

Member

WebExtensions are growing a tiny omnibox suggestion feature:

https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/omnibox/SuggestResult

But ...

  1. Add-on omnibox suggestions are only shown when the user enter's the add-on's omnibox keyword, and we only get 1 keyword. So it would have to be something like "contain facebook.com"
  2. The SuggestResult description is plain text, so we can't style the suggestion. We would only be able to do something like "Open facebook.com in your Personal container".

The other UI mock-ups shown here go well beyond WebExtensions, or even SDK add-on abilities. So we may not want to even try them? 😐

Member

groovecoder commented Apr 3, 2017

WebExtensions are growing a tiny omnibox suggestion feature:

https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/omnibox/SuggestResult

But ...

  1. Add-on omnibox suggestions are only shown when the user enter's the add-on's omnibox keyword, and we only get 1 keyword. So it would have to be something like "contain facebook.com"
  2. The SuggestResult description is plain text, so we can't style the suggestion. We would only be able to do something like "Open facebook.com in your Personal container".

The other UI mock-ups shown here go well beyond WebExtensions, or even SDK add-on abilities. So we may not want to even try them? 😐

groovecoder added a commit that referenced this issue Apr 3, 2017

groovecoder added a commit that referenced this issue Apr 4, 2017

Merge pull request #412 from mozilla/assignment-telemetry
for #306: Telemetry for container assignment events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment