New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permanent cookies set on same site in different containers lost after second browser restart #397

Closed
nkestrel opened this Issue Mar 20, 2017 · 7 comments

Comments

Projects
None yet
5 participants
@nkestrel

nkestrel commented Mar 20, 2017

  • Firefox 54
  • Containers Experiment 2.0.0

I was using containers previously with privacy.userContext.enabled and often lost cookies after a restart due to Bug 1283709 which was later fixed. This extension appears to have brought this problem back, if I disable it the problem goes away and cookies are retained across sessions like normal.

Update:

STR

  1. Create a container tab, go to http://winware.org/en/cookie-permanent.php and set a permanent cookie with a name.
  2. Create a different container tab and do the same.
  3. Shutdown and restart Firefox.
  4. Go back to the site in each container, note that both cookies still exist.
  5. Shutdown and restart Firefox a second time.
  6. Go back to the site in each container and note that now only one of the container tabs has remembered its permanent cookie.

Tested Firefox 52 and Nightly 55 with privacy.userContext.enabled = true.

Note that this doesn't happen with session cookies that are successfully retained in each container by session restore.

Upstream Bug 1334587.

@groovecoder

This comment has been minimized.

Show comment
Hide comment
@groovecoder

groovecoder Mar 20, 2017

Member

Thanks for the bug-report. Can you add the minimum/exact steps to reproduce?

Member

groovecoder commented Mar 20, 2017

Thanks for the bug-report. Can you add the minimum/exact steps to reproduce?

@jonathanKingston jonathanKingston added this to the Stretch milestone Mar 24, 2017

@kjozwiak

This comment has been minimized.

Show comment
Hide comment
@kjozwiak

kjozwiak Mar 28, 2017

I couldn't reproduce this using the latest fx54.0a2. I logged into several different websites using a variation of default containers (Personal, Work etc..) and several custom containers and went through:

  • restoring sessions using about:home
  • restoring sessions using "Show your windows and tabs from last time" via about:preferences
  • completely closing FX and manually reopening all the containers one by one
  • checking and making sure cookies aren't being removed from cookies.sqlite

@nkestrel, it could it be possible that you ran into #374 when the container experiment was updated to 2.0.0? When you noticed this happen, were all your custom containers destroyed as well? #374 would have destroyed all the custom containers but would have left the default containers (Personal, Work, Banking, Shopping) intact. Have you noticed this happening on a regular basis? Or did it just happen the one time?

If this is a regular occurrence, could you provide a bit more detail? Are you being logged out of all your sessions across all containers on a regular basis? Does this happen when restoring sessions or after restarting FX? Is it only particular websites that you're noticing sessions being logged out?

kjozwiak commented Mar 28, 2017

I couldn't reproduce this using the latest fx54.0a2. I logged into several different websites using a variation of default containers (Personal, Work etc..) and several custom containers and went through:

  • restoring sessions using about:home
  • restoring sessions using "Show your windows and tabs from last time" via about:preferences
  • completely closing FX and manually reopening all the containers one by one
  • checking and making sure cookies aren't being removed from cookies.sqlite

@nkestrel, it could it be possible that you ran into #374 when the container experiment was updated to 2.0.0? When you noticed this happen, were all your custom containers destroyed as well? #374 would have destroyed all the custom containers but would have left the default containers (Personal, Work, Banking, Shopping) intact. Have you noticed this happening on a regular basis? Or did it just happen the one time?

If this is a regular occurrence, could you provide a bit more detail? Are you being logged out of all your sessions across all containers on a regular basis? Does this happen when restoring sessions or after restarting FX? Is it only particular websites that you're noticing sessions being logged out?

@kjozwiak kjozwiak added the bug label Mar 30, 2017

@jonathanKingston

This comment has been minimized.

Show comment
Hide comment
@jonathanKingston

jonathanKingston Apr 5, 2017

Member

Was this the bug we mentioned in the last triage, where we mentioned using session restore?

/cc @bakulf @groovecoder @kjozwiak

Member

jonathanKingston commented Apr 5, 2017

Was this the bug we mentioned in the last triage, where we mentioned using session restore?

/cc @bakulf @groovecoder @kjozwiak

@nkestrel nkestrel changed the title from Cookies being lost after browser restart to Permanent cookies set on same site in different containers lost after second browser restart Apr 6, 2017

@nkestrel

This comment has been minimized.

Show comment
Hide comment
@nkestrel

nkestrel Apr 6, 2017

Added STR. I was mistaken this was caused by the Experiment and is actually caused by privacy.userContext.enabled.

nkestrel commented Apr 6, 2017

Added STR. I was mistaken this was caused by the Experiment and is actually caused by privacy.userContext.enabled.

@nkestrel

This comment has been minimized.

Show comment
Hide comment
@nkestrel

nkestrel commented Apr 12, 2017

Upstream Bug 1334587.

@openjck

This comment has been minimized.

Show comment
Hide comment
@openjck

openjck Aug 14, 2017

Has this been fixed now that bug 1334587 is fixed?

openjck commented Aug 14, 2017

Has this been fixed now that bug 1334587 is fixed?

@nkestrel

This comment has been minimized.

Show comment
Hide comment
@nkestrel

nkestrel Aug 15, 2017

@openjck yes, thanks for the reminder.

nkestrel commented Aug 15, 2017

@openjck yes, thanks for the reminder.

@nkestrel nkestrel closed this Aug 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment