Skip to content

Explicitly set foreground color of #redirect-url in dark mode - #1532

Merged
groovecoder merged 1 commit into
mozilla:masterfrom
scar45:fix/dark-mode-redirect-url-color
Oct 16, 2019
Merged

groovecoder merged 1 commit into
mozilla:masterfrom
scar45:fix/dark-mode-redirect-url-color

Conversation

@scar45

@scar45 scar45 commented Oct 12, 2019

Copy link
Copy Markdown
Contributor

When using Firefox Multi-Account Containers in KDE Plasma, with a dark theme applied, the #redirect-url element contrast is very poor (black-on-black basically):
image

This tiny PR sets the foreground color (via dark mode media query) to be #eee, or slightly-dimmed white:
image

All tests passed via npm test.

@groovecoder groovecoder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice quick fix. It'd be great to re-style the whole interstitial page for dark theme, but this is a big improvement.

@groovecoder
groovecoder merged commit 27d51f8 into mozilla:master Oct 16, 2019
@scar45
scar45 deleted the fix/dark-mode-redirect-url-color branch October 17, 2019 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants