Repository navigation
Explicitly set foreground color of #redirect-url in dark mode - #1532
Merged
groovecoder merged 1 commit intoOct 16, 2019
Merged
Conversation
groovecoder
approved these changes
Oct 16, 2019
groovecoder
left a comment
Member
There was a problem hiding this comment.
Nice quick fix. It'd be great to re-style the whole interstitial page for dark theme, but this is a big improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using Firefox Multi-Account Containers in KDE Plasma, with a dark theme applied, the

#redirect-urlelement contrast is very poor (black-on-black basically):This tiny PR sets the foreground color (via dark mode media query) to be

#eee, or slightly-dimmed white:All tests passed via
npm test.