Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Placeholder text in FF is the same color as regular input #70

Merged
merged 1 commit into from

3 participants

@peterbe
Owner

On the "Enter a new project title..." the placeholder text is the same color as the regular input so it's bad for usability because I think something has already been written and that I can't select it to remove it.

Identity have the same issue and this patch suggests a solution:

https://github.com/mozilla/browserid/pull/2189/files

@karthikv

Ah, good point. I'll add color contrast.

@karthikv karthikv was assigned
@karthikv

@ednapiranha Ready for review.

@ednapiranha ednapiranha merged commit b888dd4 into mozilla:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 10 additions and 0 deletions.
  1. +10 −0 public/stylesheets/main.styl
View
10 public/stylesheets/main.styl
@@ -164,6 +164,16 @@ header a
box-shadow(inset 0 3px 4px #303030)
color #eee
+// must keep the following two sets of selectors separate, as browsers will
+// ignore a whole line of selectors if one fails
+#sidebar input[type='text']:-moz-placeholder,
+#sidebar textarea:-moz-placeholder
+ color #888
+
+#sidebar input[type='text']::-webkit-input-placeholder,
+#sidebar textarea::-webkit-input-placeholder
+ color #888
+
#sidebar .field-select
border 1px solid #444
Something went wrong with that request. Please try again.