Harmony modules #18
Harmony modules #18
Conversation
- proper treatment of global mirror object
This comment has been minimized.
This comment has been minimized.
|
I have one concern here. In Zaphod, I'm relying on the noPropFound hook to give me a way to look up elements from the HTML. Here is the Zaphod snippet just for reference: I might be able to do the same thing without it, but if possible I'd like to keep that hook. (On the other hand, if we decide to remove it, we should also get rid of it from jsdefs.js.) |
This comment has been minimized.
This comment has been minimized.
|
Same note here about noPropFound. |
This comment has been minimized.
This comment has been minimized.
|
no {} |
This comment has been minimized.
This comment has been minimized.
|
no {} |
This comment has been minimized.
This comment has been minimized.
|
Maybe say why, if the token is blacklisted? Could be a followup. It'd be nice to say "modules aren't allowed because you aren't in Harmony mode". |
This comment has been minimized.
This comment has been minimized.
|
Here too. |
This comment has been minimized.
This comment has been minimized.
|
Just use an object or an array lookup, perhaps? |
This comment has been minimized.
This comment has been minimized.
|
Might want a comment here saying |
This comment has been minimized.
This comment has been minimized.
|
no {} |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
Not sure what this is for… |
This comment has been minimized.
This comment has been minimized.
|
Could you add a comment explaining what |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
This rocks. |
This comment has been minimized.
This comment has been minimized.
|
r=me |
This comment has been minimized.
This comment has been minimized.
|
Maybe "mixin"? |
This comment has been minimized.
This comment has been minimized.
|
r=me |
This comment has been minimized.
This comment has been minimized.
|
r=me |
Adds a prototype of Harmony modules to the interpreter, when in Harmony mode (./njs -H).
Dave