chore: Fix some zizmor lints - #2721
Merged
Merged
Conversation
These show up when I run locally, but not when we run in CI?
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
June 9, 2025 14:58
Contributor
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to b41c82b. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Contributor
Benchmark resultsPerformance differences relative to 079b02e. 1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: Change within noise threshold. time: [625.62 ms 626.46 ms 627.33 ms]
thrpt: [159.41 MiB/s 159.63 MiB/s 159.84 MiB/s]
change:
time: [−0.6624% −0.4682% −0.2830%] (p = 0.00 < 0.05)
thrpt: [+0.2838% +0.4704% +0.6668%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [308.53 ms 310.03 ms 311.52 ms]
thrpt: [32.100 Kelem/s 32.254 Kelem/s 32.412 Kelem/s]
change:
time: [−0.3758% +0.3582% +1.0635%] (p = 0.33 > 0.05)
thrpt: [−1.0523% −0.3569% +0.3772%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [27.102 ms 27.259 ms 27.439 ms]
thrpt: [36.445 elem/s 36.685 elem/s 36.898 elem/s]
change:
time: [−1.0343% −0.1237% +0.7919%] (p = 0.79 > 0.05)
thrpt: [−0.7857% +0.1238% +1.0451%]
1-conn/1-100mb-req/mtu-1504 (aka. Upload)/client: 💚 Performance has improved. time: [635.86 ms 637.07 ms 638.28 ms]
thrpt: [156.67 MiB/s 156.97 MiB/s 157.27 MiB/s]
change:
time: [−5.5235% −3.3316% −1.3411%] (p = 0.00 < 0.05)
thrpt: [+1.3594% +3.4464% +5.8465%]
decode 4096 bytes, mask ff: No change in performance detected. time: [11.792 µs 11.820 µs 11.856 µs]
change: [−0.8214% −0.2733% +0.2184%] (p = 0.33 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [3.0219 ms 3.0315 ms 3.0426 ms]
change: [−0.4083% +0.0462% +0.5246%] (p = 0.87 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.935 µs 19.983 µs 20.038 µs]
change: [−0.6606% −0.0278% +0.5922%] (p = 0.94 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [5.0477 ms 5.0594 ms 5.0726 ms]
change: [−0.3192% +0.0321% +0.3943%] (p = 0.88 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [8.2761 µs 8.3071 µs 8.3447 µs]
change: [−0.3392% +0.3176% +0.9908%] (p = 0.38 > 0.05)
decode 1048576 bytes, mask 3f: No change in performance detected. time: [1.5853 ms 1.5908 ms 1.5977 ms]
change: [−0.5358% −0.0087% +0.5131%] (p = 0.89 > 0.05)
1000 streams of 1 bytes/multistream: Change within noise threshold. time: [48.875 ns 49.211 ns 49.548 ns]
change: [+0.8048% +1.7408% +2.7813%] (p = 0.00 < 0.05)
1000 streams of 1000 bytes/multistream: 💔 Performance has regressed. time: [50.493 ns 50.859 ns 51.223 ns]
change: [+4.5849% +5.5758% +6.5501%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 1+1 entries: Change within noise threshold. time: [88.737 ns 89.110 ns 89.473 ns]
change: [+0.2946% +0.6997% +1.1290%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 3+1 entries: Change within noise threshold. time: [106.50 ns 106.83 ns 107.18 ns]
change: [+0.4915% +1.1049% +1.9077%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 10+1 entries: Change within noise threshold. time: [106.10 ns 106.52 ns 107.02 ns]
change: [+0.7142% +1.1035% +1.5519%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [89.579 ns 89.664 ns 89.767 ns]
change: [−0.6460% +0.1891% +0.9768%] (p = 0.66 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [110.36 ms 110.42 ms 110.48 ms]
change: [−0.1862% −0.1153% −0.0428%] (p = 0.00 < 0.05)
SentPackets::take_ranges: No change in performance detected. time: [7.6287 µs 7.9411 µs 8.2122 µs]
change: [−6.7733% +5.0992% +18.801%] (p = 0.47 > 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [34.734 ms 34.796 ms 34.859 ms]
change: [+0.4736% +0.7267% +0.9973%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold. time: [35.706 ms 35.816 ms 35.927 ms]
change: [+1.1806% +1.5952% +2.0247%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [34.545 ms 34.594 ms 34.642 ms]
change: [+1.1580% +1.3540% +1.5487%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [36.055 ms 36.111 ms 36.168 ms]
change: [+0.7757% +0.9913% +1.2231%] (p = 0.00 < 0.05)
Client/server transfer resultsPerformance differences relative to 079b02e. Transfer of 33554432 bytes over loopback, min. 100 runs. All unit-less numbers are in milliseconds.
Download data for |
Contributor
|
Bencher Report| Branch | chore-zizmor-fixes |
| Testbed | t-linux64-ms-280 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| 1-conn/1-100mb-req/mtu-1504 (aka. Upload)/client | 📈 view plot 🚷 view threshold | 637,070,000.00 ns(-1.64%)Baseline: 647,688,333.33 ns | 674,363,156.06 ns (94.47%) |
| 1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client | 📈 view plot 🚷 view threshold | 626,460,000.00 ns(-0.62%)Baseline: 630,396,666.67 ns | 639,921,393.46 ns (97.90%) |
| 1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client | 📈 view plot 🚷 view threshold | 27,259,000.00 ns(+0.21%)Baseline: 27,202,000.00 ns | 27,402,658.20 ns (99.48%) |
| 1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client | 📈 view plot 🚷 view threshold | 310,030,000.00 ns(+0.22%)Baseline: 309,355,000.00 ns | 310,746,843.68 ns (99.77%) |
| 1000 streams of 1 bytes/multistream | 📈 view plot 🚷 view threshold | 49.21 ns(+0.82%)Baseline: 48.81 ns | 51.47 ns (95.62%) |
| 1000 streams of 1000 bytes/multistream | 📈 view plot 🚷 view threshold | 50.86 ns(+3.96%)Baseline: 48.92 ns | 52.23 ns (97.37%) |
| RxStreamOrderer::inbound_frame() | 📈 view plot 🚷 view threshold | 110,420,000.00 ns(-0.25%)Baseline: 110,691,666.67 ns | 111,599,868.83 ns (98.94%) |
| SentPackets::take_ranges | 📈 view plot 🚷 view threshold | 7,941.10 ns(+0.21%)Baseline: 7,924.22 ns | 7,980.96 ns (99.50%) |
| coalesce_acked_from_zero 1+1 entries | 📈 view plot 🚷 view threshold | 89.11 ns(+0.35%)Baseline: 88.80 ns | 89.84 ns (99.19%) |
| coalesce_acked_from_zero 10+1 entries | 📈 view plot 🚷 view threshold | 106.52 ns(+0.41%)Baseline: 106.08 ns | 107.74 ns (98.87%) |
| coalesce_acked_from_zero 1000+1 entries | 📈 view plot 🚷 view threshold | 89.66 ns(+0.18%)Baseline: 89.51 ns | 90.69 ns (98.87%) |
| coalesce_acked_from_zero 3+1 entries | 📈 view plot 🚷 view threshold | 106.83 ns(+0.03%)Baseline: 106.80 ns | 108.30 ns (98.64%) |
| decode 1048576 bytes, mask 3f | 📈 view plot 🚷 view threshold | 1,590,800.00 ns(-0.05%)Baseline: 1,591,600.00 ns | 1,596,923.97 ns (99.62%) |
| decode 1048576 bytes, mask 7f | 📈 view plot 🚷 view threshold | 5,059,400.00 ns(+0.03%)Baseline: 5,058,116.67 ns | 5,060,212.82 ns (99.98%) |
| decode 1048576 bytes, mask ff | 📈 view plot 🚷 view threshold | 3,031,500.00 ns(+0.02%)Baseline: 3,030,816.67 ns | 3,037,007.34 ns (99.82%) |
| decode 4096 bytes, mask 3f | 📈 view plot 🚷 view threshold | 8,307.10 ns(+0.21%)Baseline: 8,290.10 ns | 8,362.09 ns (99.34%) |
| decode 4096 bytes, mask 7f | 📈 view plot 🚷 view threshold | 19,983.00 ns(+0.02%)Baseline: 19,979.17 ns | 20,017.41 ns (99.83%) |
| decode 4096 bytes, mask ff | 📈 view plot 🚷 view threshold | 11,820.00 ns(-0.14%)Baseline: 11,837.00 ns | 11,886.15 ns (99.44%) |
| transfer/pacing-false/same-seed | 📈 view plot 🚷 view threshold | 34,594,000.00 ns(+0.51%)Baseline: 34,420,166.67 ns | 35,225,406.01 ns (98.21%) |
| transfer/pacing-false/varying-seeds | 📈 view plot 🚷 view threshold | 34,796,000.00 ns(+0.47%)Baseline: 34,632,500.00 ns | 35,356,459.95 ns (98.41%) |
| transfer/pacing-true/same-seed | 📈 view plot 🚷 view threshold | 36,111,000.00 ns(-0.31%)Baseline: 36,223,333.33 ns | 37,433,145.65 ns (96.47%) |
| transfer/pacing-true/varying-seeds | 📈 view plot 🚷 view threshold | 35,816,000.00 ns(+0.88%)Baseline: 35,504,833.33 ns | 36,200,751.56 ns (98.94%) |
Contributor
|
| Branch | chore-zizmor-fixes |
| Testbed | t-linux64-ms-280 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| s2n vs. neqo (cubic, paced) | 📈 view plot 🚷 view threshold | 307.37 ms(-2.53%)Baseline: 315.34 ms | 354.38 ms (86.73%) |
mxinden
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These show up when I run locally, but not when we run in CI?