Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

[customize-titlebar] Unable to revert changes if variables was added by clicking on the tree #108

Open
xabolcs opened this Issue · 11 comments

3 participants

@xabolcs
Owner

The comment below, from tonymec describes the problem:

nightlytt-3.4pre-issue-31-5e0db21c951c.xpi

Clicking an element line adds it to the input value. The title is immediately updated, even before I close the dialog by clicking "OK". Clicking "Cancel" instead in the dialog does not undo these changes, IOW the "Cancel" button is actually an "OK" button.
The fact that browser.preferences.instantApply is set to false (which is not the default on Linux) in about:config doesn't prevent this behaviour.

And the root cause is:

Ohh, this is a "known issue".
Introduced in harth's commit 3bb023c!

"OK" and "Cancel" button works, but clicking on the tree to add variables to title also applies the changes immediately.
"Cancel" button reverts only the changes only if You edit the textbox by hand!

@xabolcs
Owner

Based on 3bb023c was shipped almost two year ago (as NTT 3.3) and IHMO the user base are accustomed this wrong behavior, I vote for this is not a blocker for Milestone 3.4.

@whimboo
Owner

Lets get this fixed for 3.5 then.

@xabolcs
Owner

I've got a wip patch, but the comment in commit 3bb023c is still in effect:

// manually set pref, pref change isn't triggered if we just set the value

Clearing milestone 3.5.

@tonymec
Owner

"The user base are accustomed to this wrong behaviour", maybe, maybe not.

  • I don't think users customize their titlebar very often. Of course I can't speak for other people, but I set the titlebar customization at some setting I like, then I leave it at that — for years.
  • Until issue #31 gets fixed, SeaMonkey users have no title customization. They can, at the most, set nightly.templates.title in advance by means of about:config with the help of the wiki page, and that will work out of the box as soon as issue #31 gets fixed. OTOH, SeaMonkey users are of course a very small fraction of the users of Gecko-based applications; but I would bet (based on a guess, not on actual measure) that a higher proportion of them use "technical" extensions like NTT, than of "average Mozilla users" in general. (This guess should be taken with a grain of salt: I know I'm far from being a typical user. I've read somewhere that most users have no more than 10 add-ons installed; see this collection for a set of most of the add-ons that I use, all 80 of them installed in SeaMonkey, and I left out those not available at AMO and those that I have installed but not enabled in the hope that someday they will support current SeaMonkey trunk builds again.)
  • See also the comment I recently made in pull request #104 (which fixes issue #31 ), having forgotten that I had already noticed the same behaviour 6 months ago, thus triggering the opening of the present issue.
@whimboo
Owner

Do we miss to catch some events here when closing the customization dialog?

"Cancel" button reverts only the changes only if You edit the textbox by hand!

So what happens when we click on the tree items? Do we automatically update the textbox? Why don't we revert the changes? What's broken with the textbox?

@xabolcs
Owner

I don't know what is happening here, and why doesn't work my wip patch.

@xabolcs
Owner

Referring to @tonymec (""The user base are accustomed to this wrong behaviour", maybe, maybe not.") it would be nice to ship this fix with #31... which is landed so with v3.6.
Or at least provide a "Known Issues" list to AMO users. (Btw there are other open - and old - bugs too.)

@tonymec
Owner

Yes, a "Known Issues" list would be nice. :smile:

@whimboo
Owner

Agreed. We can use AMO for that.

@xabolcs
Owner

Updated Addon listing at AMO.

Screenshot link:
thmbhamcgaaeo

@whimboo
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.