Cleanup unused nightlyApp.storedTitle (practically from browser.js) #111

xabolcs opened this Issue Nov 16, 2012 · 0 comments


None yet

1 participant

xabolcs commented Nov 16, 2012

From Pull #104.

xabolcs commented:

In commit 3bb023c1c4da harthur moved away from this initial, storedTitle related implementation of "title computing".
After that nightly.variables.defaulttitle became a getter. Therefore assigning a value to it is a no-op.
Or just a warning in the Error Console if javascript.options.strict is enabled:

TypeError: setting a property that has only a getter

Examining the commit, You could get the resolution that nightlyApp.storedTitle isn't used in the new version.
So it can be removed. (And should be removed in browser.js!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment