Restart Prompt Missing Icon #47

Closed
brianking opened this Issue Mar 22, 2012 · 11 comments

Projects

None yet

3 participants

@brianking
Member

When we enable/disable add-on compatibility, a doorhanger prompt is shown. It is missing an icon and looks bare/unbalanced.

http://briks.si/misc/ntt/NTTreStart.png

Mozilla/5.0 (Windows NT 6.0; rv:13.0) Gecko/20120320 Firefox/13.0a2 ID:20120320042012

@whimboo
Contributor
whimboo commented Mar 22, 2012

What type of panel are we using here? A doorhanger? Shouldn't be that hard to get this fixed.

@xabolcs
Collaborator
xabolcs commented Mar 22, 2012

For help about doorhangers take a look at MDN.

@whimboo would you mind to label as mentored? Ohh I see now, it's labeled! :)
Of course some "specification" would be nice:
what an icon(s) should be shown, etc.

@whimboo
Contributor
whimboo commented Mar 22, 2012

Probably the same as the one in the location bar the door hanger points to.

@xabolcs
Collaborator
xabolcs commented Mar 23, 2012

FYI - noticed a doorhanger related fix in TestPilot's changelog:

  • Fixes the doorhanger rendering bug in Fx 13+: Bug 725850
@whimboo
Contributor
whimboo commented Mar 23, 2012

I don't see that there has an icon set. They have added a border image but that's different.

@brianking brianking added a commit to brianking/nightlytt that referenced this issue Mar 26, 2012
@brianking brianking Issue #47 : Icon in compat restart doorhanger 0637ab5
@brianking
Member

I have fixed this and will submit it once my current pull request queue is empty. Can I have multiple pull requests simultaneously for different commits/issues?

Kind of related to this big. The globe we use for branding. Is this intentionally different than the Firefox Nightly brand icon?

@xabolcs
Collaborator
xabolcs commented Mar 26, 2012

brianking commented

Can I have multiple pull requests simultaneously for different commits/issues?

Short: yes, You could have.
Long: yes, You could have, but 1: all of them should be on top of mozilla/master and 2: should shouldn't be rebased to, but should do a merge from mozilla/master and collapsed into one commit before merge (=after the "r+").

The globe we use for branding.

Hm? It's not a moon?

EDIT: shouldn't rebase a pull request!

@xabolcs
Collaborator
xabolcs commented Mar 26, 2012

Uhh forgot to explicitly mention that You also have to branch your repo based on the issues.

For example:

  • your master = mozilla / master
  • your named "issue-47-restart-prompt" branch = pull request XY
  • your another named "issue-14-compatibility" branch = pull request 48

But now, don't branch fa963bb and 6385223 from pull request 48 (just 0637ab5 as whimboo said).

@brianking
Member

Ok thanks, that makes sense. I'll try to clean this up in a bit.

@whimboo
Contributor
whimboo commented Mar 26, 2012

re: the icon. I thought about that too. Not sure if we would be allowed to use the icon from Nightly. I kinda would like to see a difference in. Probably we could figure out a better icon with design. You can file a new issue on it please.

@brianking brianking added a commit to brianking/nightlytt that referenced this issue Mar 26, 2012
@brianking brianking Revert "Issue #47 : Icon in compat restart doorhanger"
This reverts commit 0637ab5.
3e1b7b3
@brianking brianking added a commit to brianking/nightlytt that referenced this issue Mar 26, 2012
@brianking brianking Revert "Revert "Issue #47 : Icon in compat restart doorhanger""
This reverts commit 3e1b7b3.
c6f69e0
@brianking brianking added a commit to brianking/nightlytt that referenced this issue Mar 26, 2012
@brianking brianking Revert "Revert "Revert "Issue #47 : Icon in compat restart doorhanger"""
This reverts commit c6f69e0.
2dbd18a
@brianking brianking added a commit to brianking/nightlytt that referenced this issue Mar 27, 2012
@brianking brianking Issue #47 : Restart Prompt Missing Icon 94edb25
@whimboo
Contributor
whimboo commented Mar 28, 2012

Code has been merged.

@whimboo whimboo closed this Mar 28, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment