[force-compatibility] Detect the application version automatically and setup the right compatibility pref #52

Closed
xabolcs opened this Issue Mar 27, 2012 · 5 comments

Projects

None yet

2 participants

@xabolcs

whimboo comented in #48:

... which has been detected the application version automatically and setup the right compatibility pref? That way we wouldn't have to do any of the above prefs addition anymore.

xabolcs commented in #14:

IMHO if somebody would like to touch nttAddonCompatibilityService.js (read: revamp NTT's force-compatiblity feature) then he/she should consider about Kris Maglione's work in his addon in addition - how to set only the necessary and sufficient subset of extensions.checkCompatibility.* preferences.

@whimboo

Setting target milestone to 3.4 for now. If someone wants to work on it and a patch is available even for 3.3 I'm happy to take it.

@xabolcs

I'll take this.

My resolution is greatly inspired by Kris Maglione's addon. Which is MIT Licensed.
Of course, the fix isn't going to be a copy-paste.

Should I put a LICENSE.MIT to the extension dir, next to LICENSE?
Or just put a link in the Related Add-ons section in Readme.md?

@whimboo

Would you mind asking gerv on IRC? I'm not sure what's the best option here and he can definitely answer your question.

@xabolcs xabolcs added a commit to xabolcs/nightlytt that referenced this issue Jun 6, 2012
@xabolcs xabolcs Issue #52 - Part 1: updated setCompatPrefs() c755e07
@xabolcs xabolcs added a commit to xabolcs/nightlytt that referenced this issue Jun 7, 2012
@xabolcs xabolcs Issue #52 - Part 2: on demand restart f301158
@xabolcs xabolcs added a commit to xabolcs/nightlytt that referenced this issue Jun 7, 2012
@xabolcs xabolcs Issue #52 - Part 3: no need to get application startup notifications 95d4f08
@xabolcs xabolcs was assigned Aug 24, 2012
@xabolcs

For milestone 3.4 pull #103 was taken. Targeting milestone 3.5.

@xabolcs xabolcs added a commit to xabolcs/nightlytt that referenced this issue Mar 25, 2013
@xabolcs xabolcs Issue #52 - addressing comments, round 3, part 2
- "nttACS" -> "_nttACS"
e616eda
@xabolcs xabolcs added a commit to xabolcs/nightlytt that referenced this issue Mar 27, 2013
@xabolcs xabolcs Issue #52 - addressing comments, round 4, part 1
- not starting a boolean in isPendingAddon()
- space nits
c4eb549
@xabolcs xabolcs added a commit to xabolcs/nightlytt that referenced this issue Mar 27, 2013
@xabolcs xabolcs Issue #52 - addressing comments, round 4, part 2
- not starting a boolean in isPendingAddon(), really
0605f66
@xabolcs xabolcs added a commit to xabolcs/nightlytt that referenced this issue Mar 27, 2013
@xabolcs xabolcs Issue #52 - addressing comments, round 4, part 3
- space nit
62388ad
@xabolcs xabolcs added a commit to xabolcs/nightlytt that referenced this issue Apr 9, 2013
@xabolcs xabolcs Issue #52 - addressing comments, round 5
- indentation
94e0e83
@xabolcs xabolcs added a commit to xabolcs/nightlytt that referenced this issue Apr 13, 2013
@xabolcs xabolcs Issue #52 - addressing comments, round 6
- obs + restartObserver is relevant only in nightlyApp.openNotification case
- nttAddonCompatibilityService space nits
4bf06c6
@xabolcs xabolcs added a commit to xabolcs/nightlytt that referenced this issue Apr 15, 2013
@xabolcs xabolcs Detect the application version automatically and setup the right comp…
…atibility pref (#52)
ae9184f
@xabolcs

Fixed by the commit ae9184f above

@xabolcs xabolcs closed this Apr 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment