'Save as...' in Screengrabber is broken due to Bug 795065 (Target Milestone: mozilla18) #99

Closed
xabolcs opened this Issue Oct 19, 2012 · 6 comments

Projects

None yet

2 participants

@xabolcs

Reporter:
JoeG on mozillaZine

Regression Bug:
Bug 795065 - Add privacy status to nsDownload

STR:

  • get Gecko 18 (or newer) based Application
  • open ScreenShot Grabber window: Nightly Tester Tools / Take Screenshot
  • push the Save As... button
  • check Error Consle for errors like in Bug 799529 comment 5:

    Error: NS_ERROR_XPC_NOT_ENOUGH_ARGS: Not enough arguments [nsITransfer.init]
    Source file: chrome://nightly/content/screenshot/screenshot.js
    Line: 184
    

Where Line: 184 is really L151.

Note to Release Engineers: fix for this should landed with the fix for #49.
@whimboo

Can we please land this separate and not include it into issue #49? I kinda would like to see this fixed in the upcoming version. And I'm not sure we can include #49 in it.

@xabolcs

I tried to say that, exactly: this and #49 should have the same target release / milestone, e.g. 3.5.
I wouldn't like to merge these issues into one!
Sorry if my comment was ambiguous.

@whimboo

But why should this land with #49? Both are fully independent. And given that this one is a regression caused by a change in Firefox I would say get it in for even 3.4. Or is it too hard to fix?

@xabolcs

#49 is about broken submission of a screenshot - where uploading applicable (e.g Tb doesn't have uploading capabilities).
This issue (#99) is about saving screenshot - which is the half of the Screenshot feature under Fx and SM, but the whole under Tb!
And the regression starts at Gecko version 18 - currently on Aurora.

So without these fixes the Screenshot feature won't be complete.
By the way they are both API change.

It's OK for me to provide a try { newAPI } catch { oldAPI }-like hotfix for this, and file a follow-up issue to for a NetUtil.jsm based fix (a mozmill like saveDataURL + file picker would be nice).

@xabolcs

Edited description

  • deleted binding to Issue #49
  • referencing JoeG's comment on mozillaZine.
@whimboo whimboo closed this Oct 26, 2012
@xabolcs xabolcs was assigned Oct 26, 2012
@xabolcs

Fixed by 0bfa5f4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment