Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Overlay Thunderbird's AppMenu. Fixes #100. #110

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
Collaborator

xabolcs commented Nov 14, 2012

This is for Issue #100.

It overlays appmenuSecondaryPane and placed after appmenu_customize.

@ghost ghost assigned xabolcs Nov 19, 2012

xabolcs added a commit to xabolcs/nightlytt that referenced this pull request Aug 6, 2013

@whimboo whimboo commented on the diff Oct 6, 2013

extension/chrome/content/messengerOverlay.xul
@@ -64,5 +64,45 @@
</menupopup>
</menu>
</menupopup>
-
+
+ <vbox id="appmenuSecondaryPane">
@whimboo

whimboo Oct 6, 2013

Contributor

Why are you naming it that way when we have ´appmenuPrimaryPane´ for the browser?

@xabolcs

xabolcs Oct 9, 2013

Collaborator

For the appmenu the left side is the primary pane, and the one on the right is the secondary.
For Firefox, there is a separator in appmenuPrimaryPane, but nothing in Thunderbird. Therefore I moved it to right.

@whimboo

whimboo Oct 9, 2013

Contributor

Would you mind to add two screenshots? I don't have Windows for testing ATM. Thanks.

@xabolcs

xabolcs Oct 9, 2013

Collaborator

And with an unopened NTT menu. Please notice the missing separator in the primarypane!

Picture deleted!

@whimboo

whimboo Oct 9, 2013

Contributor

An English version of the picture would make it easier for me to understand. :) Not sure what all those entries are.

@xabolcs

xabolcs Oct 9, 2013

Collaborator

With english text. :)

appmenus

@whimboo

whimboo Oct 9, 2013

Contributor

Ah, I see. Then it is fine for now. But I just wonder if we should update the location of the NTT menu entry for Firefox and also move it into the second menu under options. I don't think cluttering the top menu is a good choice. We might want to tackle this in a follow-up issue.

@xabolcs

xabolcs Oct 9, 2013

Collaborator

In the XUL School they speak about insertafter="appmenu_addons". Should I update code to use that, instead insertafter="appmenu_customize"?

@xabolcs

xabolcs Oct 9, 2013

Collaborator

Btw, I vote for keeping insertafter="appmenu_customize".

@whimboo

whimboo Oct 10, 2013

Contributor

What is ´appmenu_customize´? The ´Options´ submenu? If that is the case I would agree.

@xabolcs

xabolcs Oct 10, 2013

Collaborator

Yes, exactly that. See the screenshots for reference.

@whimboo

whimboo Oct 10, 2013

Contributor

Perfect. So yes, I agree with your suggestion.

@whimboo whimboo commented on an outdated diff Oct 6, 2013

extension/chrome/content/messengerOverlay.xul
@@ -64,5 +64,45 @@
</menupopup>
</menu>
</menupopup>
-
+
+ <vbox id="appmenuSecondaryPane">
+ <menu id="nightly-appmenu" label="Nightly Tester Tools" insertafter="appmenu_customize">
+ <menupopup onpopupshowing="nightly.menuPopup(event,this);">
+ <menuitem label="&nightly.openabout.label;" oncommand="nightlyApp.openAboutNightly();"/>
+ <menuseparator/>
+ <menuitem id="nightly-build-copy" label="&nightly.id.copy.label;" oncommand="nightly.copyTemplate('buildid');"/>
+ <menuitem id="nightly-build-insert" label="&nightly.id.insert.label;" oncommand="nightly.insertTemplate('buildid');"/>
+ <menuitem id="nightly-list-copy" label="&nightly.extensions.copy.label;" oncommand="nightly.copyExtensions();"/>
+ <menuitem id="nightly-list-insert" label="&nightly.extensions.insert.label;" oncommand="nightly.insertExtensions();"/>
+ <menuitem label="&nightly.openprofile.label;" oncommand="nightly.openProfileDir();"/>
@whimboo

whimboo Oct 6, 2013

Contributor

Please insert a separator similar to the Firefox app menu.

@whimboo whimboo and 1 other commented on an outdated diff Oct 6, 2013

extension/chrome/content/messengerOverlay.xul
+ <menupopup onpopupshowing="nightly.menuPopup(event,this);">
+ <menuitem label="&nightly.openabout.label;" oncommand="nightlyApp.openAboutNightly();"/>
+ <menuseparator/>
+ <menuitem id="nightly-build-copy" label="&nightly.id.copy.label;" oncommand="nightly.copyTemplate('buildid');"/>
+ <menuitem id="nightly-build-insert" label="&nightly.id.insert.label;" oncommand="nightly.insertTemplate('buildid');"/>
+ <menuitem id="nightly-list-copy" label="&nightly.extensions.copy.label;" oncommand="nightly.copyExtensions();"/>
+ <menuitem id="nightly-list-insert" label="&nightly.extensions.insert.label;" oncommand="nightly.insertExtensions();"/>
+ <menuitem label="&nightly.openprofile.label;" oncommand="nightly.openProfileDir();"/>
+ <menuitem id="nightly-pushlog-lasttocurrent" label="&nightly.pushlog.lasttocurrent.label;" oncommand="nightly.openPushlogToCurrentBuild();"/>
+ <menuitem id="nightly-pushlog-currenttotip" label="&nightly.pushlog.currenttotip.label;" oncommand="nightly.openPushlogSinceCurrentBuild();"/>
+ <menuseparator/>
+ <menuitem label="&nightly.screenshot.full.label;" oncommand="nightly.getScreenshot();"/>
+ <menuitem label="&nightly.customize.label;" oncommand="nightly.openCustomize();"/>
+ <menu id="nightly-crashme" label="&nightly.crashme.label;">
+ <menupopup id="nightly-crashme-popup">
+ <menuitem id="nightly.crashme-nullptr" label="&nightly.crashme.nullptr.label;"
@whimboo

whimboo Oct 6, 2013

Contributor

All menuitems need an indentation of 2 more blanks.

@xabolcs

xabolcs Oct 9, 2013

Collaborator

This is also an issue for browserOverlay.xul, at least!.

Contributor

whimboo commented Oct 6, 2013

Some nits only. Otherwise it looks fine.

Issue #100 - part 2
- refreshed appmenu
- indentation
Collaborator

xabolcs commented Oct 9, 2013

Some nits only. Otherwise it looks fine.

Done.

Collaborator

xabolcs commented Oct 10, 2013

Some nits only. Otherwise it looks fine.

Done.

@whimboo: r?

Contributor

whimboo commented Oct 11, 2013

I think that looks fine! If you want please land it. Thanks!

@xabolcs xabolcs closed this Oct 13, 2013

xabolcs added a commit to xabolcs/nightlytt that referenced this pull request Oct 14, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment