Bump maxVersions to 14.0a1. Fix #37 #41

Merged
merged 1 commit into from Mar 14, 2012

Conversation

Projects
None yet
4 participants
Contributor

whimboo commented Mar 14, 2012

No description provided.

Owner

AutomatedTester commented Mar 14, 2012

Does songbird need a version bump? It hasnt been updated with this patch

Contributor

whimboo commented Mar 14, 2012

No, they are based on mozilla-1.9.2 and bump their version independently.

Owner

AutomatedTester commented Mar 14, 2012

this looks good to me then

whimboo merged commit f6397a2 into mozilla:master Mar 14, 2012

Contributor

tonymec commented Mar 17, 2012

On 14/03/12 16:30, Henrik Skupin wrote:

You can merge this Pull Request by running:

git pull https://github.com/whimboo/nightlytt versionbump

Or you can view, comment on it, or merge it online at:

#41

-- Commit Summary --

  • Bump maxVersions to 14.0a1. Fix #37

-- File Changes --

M extension/install.rdf (8)

-- Patch Links --

https://github.com/mozilla/nightlytt/pull/41.patch
https://github.com/mozilla/nightlytt/pull/41.diff


Reply to this email directly or view it on GitHub:
#41

IIUC current trunk version for Toolkit is already 14.0, not 14.0a1: e.g.
UA string for current SeaMonkey nightly is

Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120317 Firefox/14.0a1
SeaMonkey/2.11a1

(ID:20120317003014)

-- notice the absence of any "a1" or similar suffix between rv: and )

Best regards,

Tony.

Some primal termite knocked on wood.
And tasted it, and found it good.
And that is why your Cousin May
Fell through the parlor floor today.
-- Ogden Nash

Contributor

whimboo commented Mar 18, 2012

No, the Firefox version is always identical to the Toolkit version and to Gecko. You can check the application ini file of a Nightly build:

[Gecko]
MinVersion=14.0a1
MaxVersion=14.0a1

If the UA string reports other data I would consider it a bug. Given the MDN doc it also should show 14.0a1:
https://developer.mozilla.org/En/Gecko_User_Agent_String_Reference

Collaborator

xabolcs commented Mar 18, 2012

[...]
If the UA string reports other data I would consider it a bug.
[...]

IMHO that would be a feature, not a bug. See Bug 572659 and it's friends!

Contributor

whimboo commented Mar 18, 2012

Thanks. That means the MDN docs havne't been updated yet for this change happened lately in Firefox 13. Anyway, it's just the UA string which doesn't get the a1 or a2 information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment