Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Include the changeset in the Insert/Copy Build ID menuitem. Fixes #65. #73
Conversation
whimboo
reviewed
May 24, 2012
View changes
extension/chrome/content/titlebar/customize.js
| @@ -64,6 +64,7 @@ init: function() | ||
| paneTitle.addVariable("Name"); | ||
| paneTitle.addVariable("Version"); | ||
| paneTitle.addVariable("AppBuildID"); | ||
| + paneTitle.addVariable("ChangeSet"); |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
whimboo
May 24, 2012
Contributor
I would leave this as 'Changeset' as it is one word and seems to be used everywhere.
whimboo
May 24, 2012
Contributor
I would leave this as 'Changeset' as it is one word and seems to be used everywhere.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
whimboo
May 24, 2012
Contributor
Thanks xabolcs for the patch. It looks fine except the small nit. If you could update it we can get it landed.
|
Thanks xabolcs for the patch. It looks fine except the small nit. If you could update it we can get it landed. |
added a commit
that referenced
this pull request
May 25, 2012
whimboo
merged commit adf6e27
into
mozilla:master
May 25, 2012
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment|
Thanks a lot! Merged. |
xabolcs
referenced this pull request
Oct 11, 2012
Closed
Prepare to release version 3.4. Helps to fix Issue #95. #97
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
xabolcs commentedMay 23, 2012
Hi!
This pull request is about to add Changeset information in the build ID menuitem and into Titlebar Customization.
If You want a new menuitem for that then require it in #65 and close this request!
Feel free to review! Nits about wording, CamelCasing, description and other things are welcome!