Skip to content
This repository

Include the changeset in the Insert/Copy Build ID menuitem. Fixes #65. #73

Merged
merged 1 commit into from almost 2 years ago

2 participants

Szabolcs Hubai Henrik Skupin
Szabolcs Hubai
Collaborator
xabolcs commented May 23, 2012

Hi!

This pull request is about to add Changeset information in the build ID menuitem and into Titlebar Customization.
If You want a new menuitem for that then require it in #65 and close this request!

Feel free to review! Nits about wording, CamelCasing, description and other things are welcome!

extension/chrome/content/titlebar/customize.js
... ...
@@ -64,6 +64,7 @@ init: function()
64 64
   paneTitle.addVariable("Name");
65 65
   paneTitle.addVariable("Version");
66 66
   paneTitle.addVariable("AppBuildID");
  67
+  paneTitle.addVariable("ChangeSet");
2
Henrik Skupin Owner
whimboo added a note May 24, 2012

I would leave this as 'Changeset' as it is one word and seems to be used everywhere.

Szabolcs Hubai Collaborator
xabolcs added a note May 24, 2012

s/ChangeSet/Changeset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Henrik Skupin
Owner
whimboo commented May 24, 2012

Thanks xabolcs for the patch. It looks fine except the small nit. If you could update it we can get it landed.

Szabolcs Hubai Include changeset info in the Insert/Copy Build ID menuitem.
Also add to Customize Titlebar as "Changeset".
a9ef430
Henrik Skupin whimboo merged commit adf6e27 into from May 25, 2012
Henrik Skupin whimboo closed this May 25, 2012
Henrik Skupin
Owner
whimboo commented May 25, 2012

Thanks a lot! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

May 25, 2012
Szabolcs Hubai Include changeset info in the Insert/Copy Build ID menuitem.
Also add to Customize Titlebar as "Changeset".
a9ef430
This page is out of date. Refresh to see the latest.
1  extension/chrome/content/nightly.js
@@ -57,6 +57,7 @@ variables: {
57 57
   get platformversion() this.appInfo.platformVersion,
58 58
   get geckobuildid() this.appInfo.platformBuildID,
59 59
   get geckoversion() this.appInfo.platformVersion,
  60
+  get changeset() { return nightly.getChangeset(); },
60 61
   brandname: null,
61 62
   get useragent() navigator.userAgent,
62 63
   get locale() {
1  extension/chrome/content/titlebar/customize.js
@@ -64,6 +64,7 @@ init: function()
64 64
   paneTitle.addVariable("Name");
65 65
   paneTitle.addVariable("Version");
66 66
   paneTitle.addVariable("AppBuildID");
  67
+  paneTitle.addVariable("Changeset");
67 68
   paneTitle.addVariable("PlatformBuildID");
68 69
   paneTitle.addVariable("PlatformVersion");
69 70
   paneTitle.addVariable("GeckoVersion");
1  extension/chrome/locale/en-US/variables.properties
@@ -40,6 +40,7 @@ variable.Vendor.description=Application Vendor
40 40
 variable.Name.description=Application Name
41 41
 variable.Version.description=Application Version
42 42
 variable.AppBuildID.description=Application Build Identifier
  43
+variable.Changeset.description=Built from that changeset
43 44
 variable.PlatformBuildID.description=XUL Platform Build Identifier
44 45
 variable.PlatformVersion.description=XUL Platform Version
45 46
 variable.GeckoBuildID.description=Gecko Build Identifier
2  extension/defaults/preferences/variables.js
@@ -35,5 +35,5 @@
35 35
 #
36 36
 # ***** END LICENSE BLOCK *****
37 37
 #
38  
-pref("nightly.templates.buildid", "${UserAgent} ID:${AppBuildID}${Flags}");
  38
+pref("nightly.templates.buildid", "${UserAgent} ID:${AppBuildID}${Flags} CSet: ${Changeset}");
39 39
 pref("nightly.templates.title", "${DefaultTitle} (Build ${AppBuildID})");
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.