Include the changeset in the Insert/Copy Build ID menuitem. Fixes #65. #73

Merged
merged 1 commit into from May 25, 2012

Conversation

Projects
None yet
2 participants
@xabolcs
Collaborator

xabolcs commented May 23, 2012

Hi!

This pull request is about to add Changeset information in the build ID menuitem and into Titlebar Customization.
If You want a new menuitem for that then require it in #65 and close this request!

Feel free to review! Nits about wording, CamelCasing, description and other things are welcome!

@whimboo

View changes

extension/chrome/content/titlebar/customize.js
@@ -64,6 +64,7 @@ init: function()
paneTitle.addVariable("Name");
paneTitle.addVariable("Version");
paneTitle.addVariable("AppBuildID");
+ paneTitle.addVariable("ChangeSet");

This comment has been minimized.

Show comment Hide comment
@whimboo

whimboo May 24, 2012

Contributor

I would leave this as 'Changeset' as it is one word and seems to be used everywhere.

@whimboo

whimboo May 24, 2012

Contributor

I would leave this as 'Changeset' as it is one word and seems to be used everywhere.

This comment has been minimized.

Show comment Hide comment
@xabolcs

xabolcs May 25, 2012

Collaborator

s/ChangeSet/Changeset

@xabolcs

xabolcs May 25, 2012

Collaborator

s/ChangeSet/Changeset

@whimboo

This comment has been minimized.

Show comment Hide comment
@whimboo

whimboo May 24, 2012

Contributor

Thanks xabolcs for the patch. It looks fine except the small nit. If you could update it we can get it landed.

Contributor

whimboo commented May 24, 2012

Thanks xabolcs for the patch. It looks fine except the small nit. If you could update it we can get it landed.

Include changeset info in the Insert/Copy Build ID menuitem.
Also add to Customize Titlebar as "Changeset".

whimboo added a commit that referenced this pull request May 25, 2012

Merge pull request #73 from xabolcs/branch-issue-65-changeset
Include the changeset in the Insert/Copy Build ID menuitem. Fixes #65.

@whimboo whimboo merged commit adf6e27 into mozilla:master May 25, 2012

@whimboo

This comment has been minimized.

Show comment Hide comment
@whimboo

whimboo May 25, 2012

Contributor

Thanks a lot! Merged.

Contributor

whimboo commented May 25, 2012

Thanks a lot! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment