2 participants
Collaborator
xabolcs
commented
May 23, 2012
extension/chrome/content/titlebar/customize.js
| ... | ... |
@@ -64,6 +64,7 @@ init: function() |
| 64 | 64 |
paneTitle.addVariable("Name");
|
| 65 | 65 |
paneTitle.addVariable("Version");
|
| 66 | 66 |
paneTitle.addVariable("AppBuildID");
|
| 67 |
+ paneTitle.addVariable("ChangeSet");
|
| 2 |
I would leave this as 'Changeset' as it is one word and seems to be used everywhere. s/ChangeSet/Changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
|
|
Owner
whimboo
commented
May 24, 2012
Thanks xabolcs for the patch. It looks fine except the small nit. If you could update it we can get it landed.
Owner
whimboo
commented
May 25, 2012
Thanks a lot! Merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This page is out of date. Refresh to see the latest.
Showing 4 changed files with 4 additions and 1 deletion. Show diff stats
@@ -57,6 +57,7 @@ variables: {
|
||
| 57 | 57 |
get platformversion() this.appInfo.platformVersion, |
| 58 | 58 |
get geckobuildid() this.appInfo.platformBuildID, |
| 59 | 59 |
get geckoversion() this.appInfo.platformVersion, |
| 60 |
+ get changeset() { return nightly.getChangeset(); },
|
|
| 60 | 61 |
brandname: null, |
| 61 | 62 |
get useragent() navigator.userAgent, |
| 62 | 63 |
get locale() {
|
@@ -64,6 +64,7 @@ init: function() |
||
| 64 | 64 |
paneTitle.addVariable("Name");
|
| 65 | 65 |
paneTitle.addVariable("Version");
|
| 66 | 66 |
paneTitle.addVariable("AppBuildID");
|
| 67 |
+ paneTitle.addVariable("Changeset");
|
|
| 67 | 68 |
paneTitle.addVariable("PlatformBuildID");
|
| 68 | 69 |
paneTitle.addVariable("PlatformVersion");
|
| 69 | 70 |
paneTitle.addVariable("GeckoVersion");
|
@@ -40,6 +40,7 @@ variable.Vendor.description=Application Vendor |
||
| 40 | 40 |
variable.Name.description=Application Name |
| 41 | 41 |
variable.Version.description=Application Version |
| 42 | 42 |
variable.AppBuildID.description=Application Build Identifier |
| 43 |
+variable.Changeset.description=Built from that changeset |
|
| 43 | 44 |
variable.PlatformBuildID.description=XUL Platform Build Identifier |
| 44 | 45 |
variable.PlatformVersion.description=XUL Platform Version |
| 45 | 46 |
variable.GeckoBuildID.description=Gecko Build Identifier |
@@ -35,5 +35,5 @@ |
||
| 35 | 35 |
# |
| 36 | 36 |
# ***** END LICENSE BLOCK ***** |
| 37 | 37 |
# |
| 38 |
-pref("nightly.templates.buildid", "${UserAgent} ID:${AppBuildID}${Flags}");
|
|
| 38 |
+pref("nightly.templates.buildid", "${UserAgent} ID:${AppBuildID}${Flags} CSet: ${Changeset}");
|
|
| 39 | 39 |
pref("nightly.templates.title", "${DefaultTitle} (Build ${AppBuildID})");
|
Tip: You can add notes to lines in a file. Hover to the left of a line to make a note
Hi!
This pull request is about to add Changeset information in the build ID menuitem and into Titlebar Customization.
If You want a new menuitem for that then require it in #65 and close this request!
Feel free to review! Nits about wording, CamelCasing, description and other things are welcome!