Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Include about:nightly in Nightly Tester Tools' menupopup in messengerOverlay.xul. Fixes #56. #76

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
Collaborator

xabolcs commented May 30, 2012

Hi!

This is a trivial fix, "based" on @protz work.

Feel free to review it!

@whimboo whimboo commented on an outdated diff Jun 3, 2012

extension/chrome/content/messenger.js
@@ -127,4 +127,11 @@ getWindowTitleForMessenger: function(aTab)
return docTitle;
},
+openAboutNightly: function() {
+ document.getElementById("tabmail")
+ .openTab("contentTab",
@whimboo

whimboo Jun 3, 2012

Contributor

For better readability I would prefer a temporary variable.

Contributor

whimboo commented Jun 3, 2012

hm, while thinking a bit more about this request I wonder why we need this. What is included in about:nightly that users have to open it via a menuitem in the main menu? I don't see any functionality in it which would qualify for such a menu item.

Collaborator

xabolcs commented Jun 4, 2012

whimboo wrote:

... have to open via a menuitem in the main menu? ...

Pull request was renamed to Include about:nightly in the nightly-menu Nightly Tester Tools' menupopup in messengerOverlay.xul. Fixes #56.

Collaborator

xabolcs commented Jun 4, 2012

Commit updated: temporary variable for "tabmail".

@whimboo whimboo commented on an outdated diff Jun 12, 2012

extension/chrome/content/messenger.js
@@ -127,4 +127,11 @@ getWindowTitleForMessenger: function(aTab)
return docTitle;
},
+openAboutNightly: function() {
+ var tabmail = document.getElementById("tabmail");
@whimboo

whimboo Jun 12, 2012

Contributor

nit: please add a blank between function and the opening bracket.

@whimboo whimboo commented on an outdated diff Jun 12, 2012

extension/chrome/content/messenger.js
@@ -127,4 +127,11 @@ getWindowTitleForMessenger: function(aTab)
return docTitle;
},
+openAboutNightly: function() {
+ var tabmail = document.getElementById("tabmail");
+ tabmail.openTab("contentTab",
+ { contentPage: "about:nightly" }
+ );
@whimboo

whimboo Jun 12, 2012

Contributor

Why not a single line? It should be less than 80 characters.

@xabolcs xabolcs Addressed comment:
- space between
- single line
790ff8d
Collaborator

xabolcs commented Jun 15, 2012

Adressed comments:

  • a space between function and (
  • single line the tabmail.openTab() stuff

Would You mind to let me fold the changes into one commit after r+?
Thanks!

Contributor

whimboo commented Jun 18, 2012

Looks great and I will land it now.

Would You mind to let me fold the changes into one commit after r+?

I will do a merge --squash which will combine all of your commits into a single one on master.

@whimboo whimboo added a commit that referenced this pull request Jun 18, 2012

@whimboo whimboo Revert "Include about:nightly in Nightly Tester Tools' menupopup for …
…Thunderbird (#76)"

This reverts commit a31e8ab.
7650792
Contributor

whimboo commented Jun 18, 2012

Pushed:
80cd149

@whimboo whimboo closed this Jun 18, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment